bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Fastabend <john.fastabend@gmail.com>
To: andriin@fb.com, john.fastabend@gmail.com, ast@kernel.org,
	daniel@iogearbox.net
Cc: bpf@vger.kernel.org
Subject: [bpf-next PATCH] Consolidate cgroup setup in selftests
Date: Fri, 31 Jul 2020 15:08:54 -0700	[thread overview]
Message-ID: <159623300854.30208.15981610185239932416.stgit@john-XPS-13-9370> (raw)

I had this on my stack after trying to get selftests to work with
netprio cgroup running. I failed at that for the time being. The
primary problem is if we run tests in root cgroup then we need
a better way to clean them up vs deleting the directory.

But, I have this on my stack and it seems like a nice cleanup
if we want to pull it in. Andrii wdyt?

---

John Fastabend (1):
      bpf, selftests: Use single cgroup helpers for both test_sockmap/progs


 tools/testing/selftests/bpf/cgroup_helpers.c       |   23 ++++++++++++++++++++
 tools/testing/selftests/bpf/cgroup_helpers.h       |    1 +
 tools/testing/selftests/bpf/get_cgroup_id_user.c   |   14 ++----------
 tools/testing/selftests/bpf/test_cgroup_storage.c  |   17 +--------------
 tools/testing/selftests/bpf/test_dev_cgroup.c      |   15 ++-----------
 tools/testing/selftests/bpf/test_netcnt.c          |   17 ++-------------
 .../selftests/bpf/test_skb_cgroup_id_user.c        |    8 +------
 tools/testing/selftests/bpf/test_sock.c            |    8 +------
 tools/testing/selftests/bpf/test_sock_addr.c       |    8 +------
 tools/testing/selftests/bpf/test_sock_fields.c     |   14 +++---------
 tools/testing/selftests/bpf/test_socket_cookie.c   |    8 +------
 tools/testing/selftests/bpf/test_sockmap.c         |   18 ++--------------
 tools/testing/selftests/bpf/test_sysctl.c          |    8 +------
 tools/testing/selftests/bpf/test_tcpbpf_user.c     |    8 +------
 tools/testing/selftests/bpf/test_tcpnotify_user.c  |    8 +------
 15 files changed, 43 insertions(+), 132 deletions(-)

--
Signature

             reply	other threads:[~2020-07-31 22:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-31 22:08 John Fastabend [this message]
2020-07-31 22:09 ` [bpf-next PATCH] bpf, selftests: Use single cgroup helpers for both test_sockmap/progs John Fastabend
2020-08-01  3:33   ` Andrii Nakryiko
2020-08-02  3:30     ` Alexei Starovoitov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=159623300854.30208.15981610185239932416.stgit@john-XPS-13-9370 \
    --to=john.fastabend@gmail.com \
    --cc=andriin@fb.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).