From: patchwork-bot+netdevbpf@kernel.org
To: Loris Reiff <loris.reiff@liblor.ch>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org, ast@kernel.org,
daniel@iogearbox.net, andrii@kernel.org, kafai@fb.com,
songliubraving@fb.com, yhs@fb.com, john.fastabend@gmail.com,
kpsingh@kernel.org, sdf@google.com
Subject: Re: [PATCH 1/2] bpf: cgroup: Fix optlen WARN_ON_ONCE toctou
Date: Fri, 22 Jan 2021 22:20:10 +0000 [thread overview]
Message-ID: <161135401027.12943.14151458125093918348.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20210122164232.61770-1-loris.reiff@liblor.ch>
Hello:
This series was applied to bpf/bpf.git (refs/heads/master):
On Fri, 22 Jan 2021 17:42:31 +0100 you wrote:
> A toctou issue in `__cgroup_bpf_run_filter_getsockopt` can trigger a
> WARN_ON_ONCE in a check of `copy_from_user`.
> `*optlen` is checked to be non-negative in the individual getsockopt
> functions beforehand. Changing `*optlen` in a race to a negative value
> will result in a `copy_from_user(ctx.optval, optval, ctx.optlen)` with
> `ctx.optlen` being a negative integer.
>
> [...]
Here is the summary with links:
- [1/2] bpf: cgroup: Fix optlen WARN_ON_ONCE toctou
https://git.kernel.org/bpf/bpf/c/bb8b81e396f7
- [2/2] bpf: cgroup: Fix problematic bounds check
https://git.kernel.org/bpf/bpf/c/f4a2da755a7e
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2021-01-22 22:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 16:42 [PATCH 1/2] bpf: cgroup: Fix optlen WARN_ON_ONCE toctou Loris Reiff
2021-01-22 16:42 ` [PATCH 2/2] bpf: cgroup: Fix problematic bounds check Loris Reiff
2021-01-22 17:04 ` Stanislav Fomichev
2021-01-22 17:10 ` Loris Reiff
2021-01-22 17:04 ` [PATCH 1/2] bpf: cgroup: Fix optlen WARN_ON_ONCE toctou Stanislav Fomichev
2021-01-22 22:20 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161135401027.12943.14151458125093918348.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=loris.reiff@liblor.ch \
--cc=netdev@vger.kernel.org \
--cc=sdf@google.com \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).