bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Borkmann <daniel@iogearbox.net>
To: Stephen Kitt <steve@sk2.org>
Cc: Alexei Starovoitov <ast@kernel.org>,
	Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
	Yonghong Song <yhs@fb.com>,
	linux-doc@vger.kernel.org, netdev@vger.kernel.org,
	bpf@vger.kernel.org,
	"Gustavo A . R . Silva" <gustavo@embeddedor.com>
Subject: Re: [PATCH] bpf: use flexible array members, not zero-length
Date: Mon, 30 Sep 2019 10:50:04 +0200	[thread overview]
Message-ID: <20190930085004.GA1698@pc-66.home> (raw)
In-Reply-To: <20190928144814.27002-1-steve@sk2.org>

On Sat, Sep 28, 2019 at 04:48:14PM +0200, Stephen Kitt wrote:
> This switches zero-length arrays in variable-length structs to C99
> flexible array members. GCC will then ensure that the arrays are
> always the last element in the struct.
> 
> Coccinelle:
> @@
> identifier S, fld;
> type T;
> @@
> 
> struct S {
>   ...
> - T fld[0];
> + T fld[];
>   ...
> };

You did not explain the "why is it needed" part, only what your
change is doing. What [compilation?] issue are you seeing that
you're trying to fix? This sort of information must be present
in a changelog.

> Signed-off-by: Stephen Kitt <steve@sk2.org>

Thanks,
Daniel

      parent reply	other threads:[~2019-09-30  8:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-28 14:48 [PATCH] bpf: use flexible array members, not zero-length Stephen Kitt
2019-09-29  5:49 ` Gustavo A. R. Silva
2019-09-30  6:07   ` Song Liu
2019-09-30  7:38     ` [PATCH v2] " Stephen Kitt
2019-09-30 23:18       ` Gustavo A. R. Silva
2019-09-30  7:41     ` [PATCH] " Stephen Kitt
2019-09-30  8:50 ` Daniel Borkmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190930085004.GA1698@pc-66.home \
    --to=daniel@iogearbox.net \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=gustavo@embeddedor.com \
    --cc=kafai@fb.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=songliubraving@fb.com \
    --cc=steve@sk2.org \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).