From: Carlos Neira <cneirabustos@gmail.com>
To: netdev@vger.kernel.org
Cc: yhs@fb.com, ebiederm@xmission.com, brouer@redhat.com,
bpf@vger.kernel.org, cneirabustos@gmail.com
Subject: [PATCH V12 0/4] BPF: New helper to obtain namespace data from current task
Date: Tue, 1 Oct 2019 18:41:37 -0300 [thread overview]
Message-ID: <20191001214141.6294-1-cneirabustos@gmail.com> (raw)
Currently bpf_get_current_pid_tgid(), is used to do pid filtering in bcc's
scripts but this helper returns the pid as seen by the root namespace which is
fine when a bcc script is not executed inside a container.
When the process of interest is inside a container, pid filtering will not work
if bpf_get_current_pid_tgid() is used.
This helper addresses this limitation returning the pid as it's seen by the current
namespace where the script is executing.
In the future different pid_ns files may belong to different devices, according to the
discussion between Eric Biederman and Yonghong in 2017 Linux plumbers conference.
To address that situation the helper requires inum and dev_t from /proc/self/ns/pid.
This helper has the same use cases as bpf_get_current_pid_tgid() as it can be
used to do pid filtering even inside a container.
Changes from V11:
- helper: Input changed dev from u32 to u64.
- Moved self-test to test_progs.
- Remove unneeded maps in self-test.
Signed-off-by: Carlos Neira <cneirabustos@gmail.com>
Carlos Neira (4):
fs/nsfs.c: added ns_match
bpf: added new helper bpf_get_ns_current_pid_tgid
tools: Added bpf_get_ns_current_pid_tgid helper
tools/testing/selftests/bpf: Add self-tests for new helper.
fs/nsfs.c | 8 ++
include/linux/bpf.h | 1 +
include/linux/proc_ns.h | 2 +
include/uapi/linux/bpf.h | 18 +++-
kernel/bpf/core.c | 1 +
kernel/bpf/helpers.c | 36 ++++++++
kernel/trace/bpf_trace.c | 2 +
tools/include/uapi/linux/bpf.h | 18 +++-
tools/testing/selftests/bpf/bpf_helpers.h | 3 +
.../bpf/prog_tests/get_ns_current_pid_tgid.c | 85 +++++++++++++++++++
.../bpf/progs/get_ns_current_pid_tgid_kern.c | 47 ++++++++++
11 files changed, 219 insertions(+), 2 deletions(-)
create mode 100644 tools/testing/selftests/bpf/prog_tests/get_ns_current_pid_tgid.c
create mode 100644 tools/testing/selftests/bpf/progs/get_ns_current_pid_tgid_kern.c
--
2.20.1
next reply other threads:[~2019-10-01 21:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 21:41 Carlos Neira [this message]
2019-10-01 21:41 ` [PATCH V12 1/4] fs/nsfs.c: added ns_match Carlos Neira
2019-10-01 21:41 ` [PATCH V12 2/4] bpf: added new helper bpf_get_ns_current_pid_tgid Carlos Neira
2019-10-02 10:52 ` Daniel Borkmann
2019-10-03 14:52 ` Carlos Antonio Neira Bustos
2019-10-03 17:30 ` Andrii Nakryiko
2019-10-03 18:12 ` Carlos Antonio Neira Bustos
2019-10-01 21:41 ` [PATCH V12 3/4] tools: Added bpf_get_ns_current_pid_tgid helper Carlos Neira
2019-10-01 21:41 ` [PATCH V12 4/4] tools/testing/selftests/bpf: Add self-tests for new helper Carlos Neira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191001214141.6294-1-cneirabustos@gmail.com \
--to=cneirabustos@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=ebiederm@xmission.com \
--cc=netdev@vger.kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).