From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Luigi Rizzo <lrizzo@google.com>
Cc: magnus.karlsson@intel.com, bjorn.topel@intel.com,
jonathan.lemon@gmail.com, netdev@vger.kernel.org,
bpf@vger.kernel.org, rizzo@iet.unipi.it
Subject: Re: [PATCH v2] net-af_xdp: use correct number of channels from ethtool
Date: Tue, 19 Nov 2019 14:03:01 -0800 [thread overview]
Message-ID: <20191119140301.6ff669e1@cakuba.netronome.com> (raw)
In-Reply-To: <20191119001951.92930-1-lrizzo@google.com>
On Mon, 18 Nov 2019 16:19:51 -0800, Luigi Rizzo wrote:
> Drivers use different fields to report the number of channels, so take
> the maximum of all data channels (rx, tx, combined) when determining the
> size of the xsk map. The current code used only 'combined' which was set
> to 0 in some drivers e.g. mlx4.
>
> Tested: compiled and run xdpsock -q 3 -r -S on mlx4
> Signed-off-by: Luigi Rizzo <lrizzo@google.com>
Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
next prev parent reply other threads:[~2019-11-19 22:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 0:19 [PATCH v2] net-af_xdp: use correct number of channels from ethtool Luigi Rizzo
2019-11-19 8:42 ` Magnus Karlsson
2019-11-19 22:03 ` Jakub Kicinski [this message]
2019-11-19 22:07 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191119140301.6ff669e1@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=bjorn.topel@intel.com \
--cc=bpf@vger.kernel.org \
--cc=jonathan.lemon@gmail.com \
--cc=lrizzo@google.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=rizzo@iet.unipi.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).