bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Yonghong Song <yhs@fb.com>
Cc: bpf@vger.kernel.org, Alexei Starovoitov <ast@fb.com>,
	Daniel Borkmann <daniel@iogearbox.net>,
	kernel-team@fb.com
Subject: Re: [PATCH bpf-next v3 0/2] bpf: add bpf_send_signal_thread() helper
Date: Wed, 15 Jan 2020 11:51:04 -0800	[thread overview]
Message-ID: <20200115195103.vncvolqjcu72odg7@ast-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <20200115035002.602280-1-yhs@fb.com>

On Tue, Jan 14, 2020 at 07:50:02PM -0800, Yonghong Song wrote:
> Commit 8b401f9ed244 ("bpf: implement bpf_send_signal() helper") 
> added helper bpf_send_signal() which permits bpf program to
> send a signal to the current process. The signal may send to 
> any thread of the process.
>  
> This patch implemented a new helper bpf_send_signal_thread()
> to send a signal to the thread corresponding to the kernel current task. 
> This helper can simplify user space code if the thread context of
> bpf sending signal is needed in user space. Please see Patch #1 for 
> details of use case and kernel implementation.
>  
> Patch #2 added some bpf self tests for the new helper.
>  
> Changelogs:
>   v2 -> v3:
>     - More simplification for skeleton codes by removing not-needed
>       mmap code and redundantly created tracepoint link.
>   v1 -> v2: 
>     - More description for the difference between bpf_send_signal()
>       and bpf_send_signal_thread() in the uapi header bpf.h. 
>     - Use skeleton and mmap for send_signal test.

Applied. Thanks.

Though extra tests were added it's nice to see that skeleton keeps deleting
lines from selftests:
2 files changed, 73 insertions(+), 106 deletions(-)

      parent reply	other threads:[~2020-01-15 19:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-15  3:50 [PATCH bpf-next v3 0/2] bpf: add bpf_send_signal_thread() helper Yonghong Song
2020-01-15  3:50 ` [PATCH bpf-next v3 1/2] " Yonghong Song
2020-01-15  3:50 ` [PATCH bpf-next v3 2/2] tools/bpf: add self tests for bpf_send_signal_thread() Yonghong Song
2020-01-15  6:22 ` [PATCH bpf-next v3 0/2] bpf: add bpf_send_signal_thread() helper Andrii Nakryiko
2020-01-15 19:51 ` Alexei Starovoitov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200115195103.vncvolqjcu72odg7@ast-mbp.dhcp.thefacebook.com \
    --to=alexei.starovoitov@gmail.com \
    --cc=ast@fb.com \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=kernel-team@fb.com \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).