From: Tobias Klauser <tklauser@distanz.ch>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>,
Alexei Starovoitov <ast@kernel.org>,
Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
bpf@vger.kernel.org
Subject: Re: [PATCH] bpftool: fix iprofiler build on systems without /usr/include/asm symlink
Date: Wed, 11 Mar 2020 16:00:33 +0100 [thread overview]
Message-ID: <20200311150033.t5uj4pz7fwp2wz5v@distanz.ch> (raw)
In-Reply-To: <87ftefotpk.fsf@toke.dk>
On 2020-03-11 at 15:24:23 +0100, Toke Høiland-Jørgensen <toke@redhat.com> wrote:
> Tobias Klauser <tklauser@distanz.ch> writes:
>
> > On 2020-03-11 at 13:49:53 +0100, Toke Høiland-Jørgensen <toke@redhat.com> wrote:
> >> Tobias Klauser <tklauser@distanz.ch> writes:
> >>
> >> > When compiling bpftool on a system where the /usr/include/asm symlink
> >> > doesn't exist (e.g. on an Ubuntu system without gcc-multilib installed),
> >> > the build fails with:
> >> >
> >> > CLANG skeleton/profiler.bpf.o
> >> > In file included from skeleton/profiler.bpf.c:4:
> >> > In file included from /usr/include/linux/bpf.h:11:
> >> > /usr/include/linux/types.h:5:10: fatal error: 'asm/types.h' file not found
> >> > #include <asm/types.h>
> >> > ^~~~~~~~~~~~~
> >> > 1 error generated.
> >> > make: *** [Makefile:123: skeleton/profiler.bpf.o] Error 1
> >> >
> >> > To fix this, add /usr/include/$(uname -m)-linux-gnu to the clang search
> >> > path so <asm/types.h> can be found.
> >>
> >> Isn't the right thing here to just install gcc-multilib?
> >
> > For a container build we would like to avoid installing gcc-multilib
> > which pulls in additional dependencies which are otherwise not needed to
> > build bpftool. This patch would allow that.
>
> Ah, right. Well, stating that use case in the commit message would have
> been nice :)
Agree. Can also do a v2 if needed adding that rationale to the commit
message. There's anyway a typo in the patch subject
(s/iprofiler/profiler) which I could also fix :)
Tobias
next prev parent reply other threads:[~2020-03-11 15:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 12:34 [PATCH] bpftool: fix iprofiler build on systems without /usr/include/asm symlink Tobias Klauser
2020-03-11 12:49 ` Toke Høiland-Jørgensen
2020-03-11 12:53 ` Tobias Klauser
2020-03-11 14:24 ` Toke Høiland-Jørgensen
2020-03-11 15:00 ` Tobias Klauser [this message]
2020-03-11 15:55 ` Song Liu
2020-03-11 16:06 ` Tobias Klauser
2020-03-11 16:14 ` [PATCH bpf-next v2] bpftool: fix profiler " Tobias Klauser
2020-03-11 17:26 ` Alexei Starovoitov
2020-03-11 19:42 ` Tobias Klauser
2020-03-12 10:30 ` Tobias Klauser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200311150033.t5uj4pz7fwp2wz5v@distanz.ch \
--to=tklauser@distanz.ch \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=songliubraving@fb.com \
--cc=toke@redhat.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).