From: Jesper Dangaard Brouer <brouer@redhat.com>
To: David Ahern <dsahern@gmail.com>
Cc: Lorenzo Bianconi <lorenzo@kernel.org>,
bpf@vger.kernel.org, netdev@vger.kernel.org, ast@kernel.org,
davem@davemloft.net, daniel@iogearbox.net,
lorenzo.bianconi@redhat.com, dsahern@kernel.org,
brouer@redhat.com
Subject: Re: [RFC bpf-next 1/2] bpf: cpumap: add the possibility to attach a eBPF program to cpumap
Date: Fri, 22 May 2020 19:54:56 +0200 [thread overview]
Message-ID: <20200522195456.73ddb852@carbon> (raw)
In-Reply-To: <289effd3-5a58-17a3-af2f-22cc3222f2d9@gmail.com>
On Fri, 22 May 2020 11:44:04 -0600
David Ahern <dsahern@gmail.com> wrote:
> On 5/22/20 10:11 AM, Lorenzo Bianconi wrote:
> > @@ -259,28 +270,64 @@ static int cpu_map_kthread_run(void *data)
> > * kthread CPU pinned. Lockless access to ptr_ring
> > * consume side valid as no-resize allowed of queue.
> > */
> > - n = ptr_ring_consume_batched(rcpu->queue, frames, CPUMAP_BATCH);
> > + n = ptr_ring_consume_batched(rcpu->queue, xdp_frames,
> > + CPUMAP_BATCH);
> >
> > + rcu_read_lock();
> > +
> > + prog = READ_ONCE(rcpu->prog);
> > for (i = 0; i < n; i++) {
> > - void *f = frames[i];
> > + void *f = xdp_frames[i];
> > struct page *page = virt_to_page(f);
> > + struct xdp_frame *xdpf;
> > + struct xdp_buff xdp;
> > + u32 act;
> >
> > /* Bring struct page memory area to curr CPU. Read by
> > * build_skb_around via page_is_pfmemalloc(), and when
> > * freed written by page_frag_free call.
> > */
> > prefetchw(page);
> > + if (!prog) {
> > + frames[nframes++] = xdp_frames[i];
> > + continue;
> > + }
> > +
> > + xdpf = f;
> > + xdp.data_hard_start = xdpf->data - xdpf->headroom;
> > + xdp.data = xdpf->data;
> > + xdp.data_end = xdpf->data + xdpf->len;
> > + xdp.data_meta = xdpf->data - xdpf->metasize;
> > + xdp.frame_sz = xdpf->frame_sz;
> > + /* TODO: rxq */
> > +
> > + act = bpf_prog_run_xdp(prog, &xdp);
>
> Why not run the program in cpu_map_enqueue before converting from
> xdp_buff to xdp_frame?
Because we want to run the XDP-prog on the remote-CPU.
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2020-05-22 17:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 16:11 [RFC bpf-next 0/2] introduce support for XDP programs in cpumaps Lorenzo Bianconi
2020-05-22 16:11 ` [RFC bpf-next 1/2] bpf: cpumap: add the possibility to attach a eBPF program to cpumap Lorenzo Bianconi
2020-05-22 17:44 ` David Ahern
2020-05-22 17:54 ` Jesper Dangaard Brouer [this message]
2020-05-24 17:22 ` David Ahern
2020-05-22 16:11 ` [RFC bpf-next 2/2] samples/bpf: xdp_redirect_cpu: load a eBPF program on cpu_map Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200522195456.73ddb852@carbon \
--to=brouer@redhat.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=dsahern@kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).