From: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>
To: linux-kselftest@vger.kernel.org
Cc: jbenc@redhat.com, Shuah Khan <shuah@kernel.org>, bpf@vger.kernel.org
Subject: [RESEND PATCH 2/3] selftests: fix condition in run_tests
Date: Wed, 27 May 2020 10:16:58 +0300 [thread overview]
Message-ID: <20200527071659.63426-2-yauheni.kaliuta@redhat.com> (raw)
In-Reply-To: <20200527071659.63426-1-yauheni.kaliuta@redhat.com>
The check if there are any files to install in case of no files
compares "X " with "X" so never false.
Remove extra spaces. It may make sense to use make's $(if) function
here.
Signed-off-by: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>
---
tools/testing/selftests/lib.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk
index 5b82433d88e3..7a17ea815736 100644
--- a/tools/testing/selftests/lib.mk
+++ b/tools/testing/selftests/lib.mk
@@ -70,7 +70,7 @@ endef
run_tests: all
ifdef building_out_of_srctree
- @if [ "X$(TEST_PROGS) $(TEST_PROGS_EXTENDED) $(TEST_FILES)" != "X" ]; then \
+ @if [ "X$(TEST_PROGS)$(TEST_PROGS_EXTENDED)$(TEST_FILES)" != "X" ]; then \
rsync -aq $(TEST_PROGS) $(TEST_PROGS_EXTENDED) $(TEST_FILES) $(OUTPUT); \
fi
@if [ "X$(TEST_PROGS)" != "X" ]; then \
--
2.26.2
next prev parent reply other threads:[~2020-05-27 7:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 7:16 [RESEND PATCH 0/3] selftests: lib.mk improvements Yauheni Kaliuta
2020-05-27 7:16 ` [RESEND PATCH 1/3] selftests: do not use .ONESHELL Yauheni Kaliuta
2020-05-27 7:16 ` Yauheni Kaliuta [this message]
2020-05-27 7:16 ` [RESEND PATCH 3/3] selftests: simplify run_tests Yauheni Kaliuta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200527071659.63426-2-yauheni.kaliuta@redhat.com \
--to=yauheni.kaliuta@redhat.com \
--cc=bpf@vger.kernel.org \
--cc=jbenc@redhat.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).