From: Greg KH <gregkh@linuxfoundation.org>
To: Gaurav Singh <gaurav1086@gmail.com>
Cc: Jeff Dike <jdike@addtoit.com>,
Richard Weinberger <richard@nod.at>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>, Andrii Nakryiko <andriin@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@chromium.org>,
Alex Dewar <alex.dewar@gmx.co.uk>,
"open list:USER-MODE LINUX (UML)" <linux-um@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>,
"open list:BPF (Safe dynamic programs and tools)"
<netdev@vger.kernel.org>,
"open list:BPF (Safe dynamic programs and tools)"
<bpf@vger.kernel.org>
Subject: Re: [PATCH] Fix null pointer dereference in vector_user_bpf
Date: Wed, 10 Jun 2020 07:53:39 +0200 [thread overview]
Message-ID: <20200610055339.GA1865470@kroah.com> (raw)
In-Reply-To: <20200610034314.9290-1-gaurav1086@gmail.com>
On Tue, Jun 09, 2020 at 11:43:00PM -0400, Gaurav Singh wrote:
> Signed-off-by: Gaurav Singh <gaurav1086@gmail.com>
>
> The bpf_prog is being checked for !NULL after uml_kmalloc but
> later its used directly for example:
> bpf_prog->filter = bpf and is also later returned upon success.
> Fix this, do a NULL check and return right away.
>
> ---
> arch/um/drivers/vector_user.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
No signed-off-by?
next prev parent reply other threads:[~2020-06-10 5:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 3:43 [PATCH] Fix null pointer dereference in vector_user_bpf Gaurav Singh
2020-06-10 5:53 ` Greg KH [this message]
2020-06-11 2:40 Gaurav Singh
2020-06-14 1:19 Gaurav Singh
2020-06-14 6:38 ` Anton Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200610055339.GA1865470@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alex.dewar@gmx.co.uk \
--cc=andriin@fb.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=gaurav1086@gmail.com \
--cc=jdike@addtoit.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=richard@nod.at \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).