From: Yonghong Song <yhs@fb.com>
To: <bpf@vger.kernel.org>, <netdev@vger.kernel.org>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>, <kernel-team@fb.com>
Subject: [PATCH bpf-next 0/2] bpf: change uapi for bpf iterator map elements
Date: Sat, 1 Aug 2020 21:21:26 -0700 [thread overview]
Message-ID: <20200802042126.2119783-1-yhs@fb.com> (raw)
Andrii raised a concern that current uapi for bpf iterator map
element is a little restrictive and not suitable for future potential
complex customization. This is a valid suggestion, considering people
may indeed add more complex custimization to the iterator, e.g.,
cgroup_id + user_id, etc. for task or task_file. Another example might
be map_id plus additional control so that the bpf iterator may bail
out a bucket earlier if a bucket has too many elements which may hold
lock too long and impact other parts of systems.
Patch #1 modified uapi with kernel changes. Patch #2
adjusted libbpf api accordingly.
Yonghong Song (2):
bpf: change uapi for bpf iterator map elements
libbpf: support new uapi for map element bpf iterator
include/linux/bpf.h | 10 ++++---
include/uapi/linux/bpf.h | 15 +++++-----
kernel/bpf/bpf_iter.c | 52 +++++++++++++++-------------------
kernel/bpf/map_iter.c | 37 ++++++++++++++++++------
kernel/bpf/syscall.c | 2 +-
net/core/bpf_sk_storage.c | 37 ++++++++++++++++++------
tools/include/uapi/linux/bpf.h | 15 +++++-----
tools/lib/bpf/bpf.c | 4 ++-
tools/lib/bpf/bpf.h | 5 ++--
tools/lib/bpf/libbpf.c | 7 +++--
10 files changed, 115 insertions(+), 69 deletions(-)
--
2.24.1
next reply other threads:[~2020-08-02 4:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-02 4:21 Yonghong Song [this message]
2020-08-02 4:21 ` [PATCH bpf-next 1/2] bpf: change uapi for bpf iterator map elements Yonghong Song
2020-08-03 1:25 ` Andrii Nakryiko
2020-08-03 2:23 ` Yonghong Song
2020-08-03 5:11 ` Andrii Nakryiko
2020-08-03 6:21 ` Yonghong Song
2020-08-02 4:21 ` [PATCH bpf-next 2/2] libbpf: support new uapi for map element bpf iterator Yonghong Song
2020-08-03 1:35 ` Andrii Nakryiko
2020-08-03 2:30 ` Yonghong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200802042126.2119783-1-yhs@fb.com \
--to=yhs@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).