From: Jiri Olsa <jolsa@redhat.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andriin@fb.com>,
dwarves@vger.kernel.org, Networking <netdev@vger.kernel.org>,
bpf <bpf@vger.kernel.org>, Yonghong Song <yhs@fb.com>,
Hao Luo <haoluo@google.com>, Martin KaFai Lau <kafai@fb.com>,
Song Liu <songliubraving@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@chromium.org>,
Joe Lawrence <joe.lawrence@redhat.com>,
Mark Wielaard <mjw@redhat.com>
Subject: Re: [PATCH 2/3] bpf_encoder: Translate SHN_XINDEX in symbol's st_shndx values
Date: Sat, 23 Jan 2021 22:23:41 +0100 [thread overview]
Message-ID: <20210123212341.GC117714@krava> (raw)
In-Reply-To: <CAEf4BzZquSn0Th7bpVuM0M4XbTPU5-9jDPPd5RJBS5AH2zqaMA@mail.gmail.com>
On Thu, Jan 21, 2021 at 03:32:40PM -0800, Andrii Nakryiko wrote:
SNIP
> But the current variant looks broken. Oh, and
> elf_symtab__for_each_symbol() is similarly broken, can you please fix
> that as well?
we'll have to change its callers a bit, because of hanging 'else'
I'll send this separately if that's ok, when I figure out how to
test ctf code
jirka
---
diff --git a/elf_symtab.h b/elf_symtab.h
index 489e2b1a3505..6823a8c37ecf 100644
--- a/elf_symtab.h
+++ b/elf_symtab.h
@@ -99,10 +99,9 @@ elf_sym__get(Elf_Data *syms, Elf_Data *syms_sec_idx_table,
* @index: uint32_t index
* @sym: GElf_Sym iterator
*/
-#define elf_symtab__for_each_symbol(symtab, index, sym) \
- for (index = 0, gelf_getsym(symtab->syms, index, &sym);\
- index < symtab->nr_syms; \
- index++, gelf_getsym(symtab->syms, index, &sym))
+#define elf_symtab__for_each_symbol(symtab, index, sym) \
+ for (index = 0; index < symtab->nr_syms; index++) \
+ if (gelf_getsym(symtab->syms, index, &sym))
/**
* elf_symtab__for_each_symbol_index - iterate through all the symbols,
diff --git a/libctf.h b/libctf.h
index 749be8955c52..ee5412bec77e 100644
--- a/libctf.h
+++ b/libctf.h
@@ -90,11 +90,9 @@ char *ctf__string(struct ctf *ctf, uint32_t ref);
*/
#define ctf__for_each_symtab_function(ctf, index, sym) \
elf_symtab__for_each_symbol(ctf->symtab, index, sym) \
- if (ctf__ignore_symtab_function(&sym, \
+ if (!ctf__ignore_symtab_function(&sym, \
elf_sym__name(&sym, \
ctf->symtab))) \
- continue; \
- else
/**
* ctf__for_each_symtab_object - iterate thru all the symtab objects
@@ -105,11 +103,9 @@ char *ctf__string(struct ctf *ctf, uint32_t ref);
*/
#define ctf__for_each_symtab_object(ctf, index, sym) \
elf_symtab__for_each_symbol(ctf->symtab, index, sym) \
- if (ctf__ignore_symtab_object(&sym, \
+ if (!ctf__ignore_symtab_object(&sym, \
elf_sym__name(&sym, \
ctf->symtab))) \
- continue; \
- else
#endif /* _LIBCTF_H */
next prev parent reply other threads:[~2021-01-23 21:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 20:22 [PATCHv2 0/3] dwarves,libbpf: Add support to use optional extended section index table Jiri Olsa
2021-01-21 20:22 ` [PATCH 1/3] elf_symtab: Add support for SHN_XINDEX index to elf_section_by_name Jiri Olsa
2021-01-21 23:10 ` Andrii Nakryiko
2021-01-21 23:34 ` Jiri Olsa
2021-01-21 20:22 ` [PATCH 2/3] bpf_encoder: Translate SHN_XINDEX in symbol's st_shndx values Jiri Olsa
2021-01-21 23:32 ` Andrii Nakryiko
2021-01-22 9:32 ` Jiri Olsa
2021-01-22 20:46 ` Jiri Olsa
2021-01-22 22:55 ` Andrii Nakryiko
2021-01-23 18:51 ` Jiri Olsa
2021-01-23 20:07 ` Andrii Nakryiko
2021-01-23 20:21 ` Mark Wielaard
2021-01-23 20:08 ` Mark Wielaard
2021-01-23 20:15 ` Jiri Olsa
2021-01-23 21:23 ` Jiri Olsa [this message]
2021-01-24 6:08 ` Andrii Nakryiko
2021-01-21 20:22 ` [PATCH bpf-next 3/3] libbpf: Use string table index from index table if needed Jiri Olsa
2021-01-21 23:46 ` Andrii Nakryiko
-- strict thread matches above, loose matches on Subject: below --
2021-01-19 22:12 [PATCH 0/3] dwarves,libbpf: Add support to use optional extended section index table Jiri Olsa
2021-01-19 22:12 ` [PATCH 2/3] bpf_encoder: Translate SHN_XINDEX in symbol's st_shndx values Jiri Olsa
2021-01-20 2:03 ` Andrii Nakryiko
2021-01-20 12:25 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210123212341.GC117714@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=dwarves@vger.kernel.org \
--cc=haoluo@google.com \
--cc=joe.lawrence@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=mjw@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).