From: Rocco Yue <rocco.yue@mediatek.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
David Ahern <dsahern@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Felix Fietkau <nbd@nbd.name>, John Crispin <john@phrozen.org>,
Sean Wang <sean.wang@mediatek.com>,
Mark Lee <Mark-MC.Lee@mediatek.com>, <netdev@vger.kernel.org>,
<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>, <bpf@vger.kernel.org>,
<wsd_upstream@mediatek.com>, <chao.song@mediatek.com>,
<kuohong.wang@mediatek.com>, Rocco Yue <rocco.yue@mediatek.com>
Subject: Re: [PATCH 1/4] net: if_arp: add ARPHRD_PUREIP type
Date: Thu, 24 Jun 2021 11:33:53 +0800 [thread overview]
Message-ID: <20210624033353.25636-1-rocco.yue@mediatek.com> (raw)
In-Reply-To: <YNNtN3cdDL71SiNt@kroah.com>
On Wed, 2021-06-23 at 19:19 +0200, Greg KH wrote:
On Wed, Jun 23, 2021 at 07:34:49PM +0800, Rocco Yue wrote:
>> This patch add the definition of ARPHRD_PUREIP which can for
>> example be used by mobile ccmni device as device type.
>> ARPHRD_PUREIP means that this device doesn't need kernel to
>> generate ipv6 link-local address in any addr_gen_mode.
>>
>> Signed-off-by: Rocco Yue <rocco.yue@mediatek.com>
>> ---
>> include/uapi/linux/if_arp.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/include/uapi/linux/if_arp.h b/include/uapi/linux/if_arp.h
>> index c3cc5a9e5eaf..4463c9e9e8b4 100644
>> --- a/include/uapi/linux/if_arp.h
>> +++ b/include/uapi/linux/if_arp.h
>> @@ -61,6 +61,7 @@
>> #define ARPHRD_DDCMP 517 /* Digital's DDCMP protocol */
>> #define ARPHRD_RAWHDLC 518 /* Raw HDLC */
>> #define ARPHRD_RAWIP 519 /* Raw IP */
>> +#define ARPHRD_PUREIP 520 /* Pure IP */
>
> In looking at the patches, what differs "PUREIP" from "RAWIP"? It seems
Thanks for your review.
The difference between RAWIP and PUREIP is that they generate IPv6
link-local address and IPv6 global address in different ways.
RAWIP:
~~~~~~
In the ipv6_generate_eui64() function, using RAWIP will always return 0,
which will cause the kernel to automatically generate an IPv6 link-local
address in EUI64 format and an IPv6 global address in EUI64 format.
PUREIP:
~~~~~~~
After this patch set, when using PUREIP, kernel doesn't generate IPv6
link-local address regardless of which IN6_ADDR_GEN_MODE is used.
@@ static void addrconf_dev_config(struct net_device *dev)
+ if (dev->type == ARPHRD_PUREIP)
+ return;
And after recving RA message, kernel iterates over the link-local address
that exists for the interface and uses the low 64bits of the link-local
address to generate the IPv6 global address.
The general process is as follows:
ndisc_router_discovery() -> addrconf_prefix_rcv() -> ipv6_generate_eui64() -> ipv6_inherit_eui64()
> to be the same to me. If they are different, where is that documented?
>
> thanks,
>
> greg k-h
I tried to find corresponding documents about other device types, but I
am sorry I didn't find it. If it is needed, I am willing to provide.
Thanks,
Rocco
next prev parent reply other threads:[~2021-06-24 3:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 11:34 [PATCH 1/4] net: if_arp: add ARPHRD_PUREIP type Rocco Yue
2021-06-23 11:34 ` [PATCH 2/4] net: ipv6: don't generate link local address on PUREIP device Rocco Yue
2021-06-23 11:34 ` [PATCH 3/4] net: dev_is_mac_header_xmit() return false for ARPHRD_PUREIP Rocco Yue
2021-06-23 11:34 ` [PATCH 4/4] drivers: net: mediatek: initial implementation of ccmni Rocco Yue
2021-06-23 17:25 ` Greg KH
2021-06-23 17:31 ` Greg KH
2021-06-24 11:53 ` [PATCH 1/4] net: if_arp: add ARPHRD_PUREIP type Rocco Yue
2021-06-24 12:23 ` Greg KH
2021-06-24 15:55 ` [PATCH 4/4] drivers: net: mediatek: initial implementation of ccmni Rocco Yue
2021-06-24 16:51 ` Greg KH
2021-06-28 7:18 ` Rocco Yue
2021-06-28 9:30 ` Greg KH
2021-06-23 17:19 ` [PATCH 1/4] net: if_arp: add ARPHRD_PUREIP type Greg KH
2021-06-24 3:33 ` Rocco Yue [this message]
2021-06-24 5:15 ` David Ahern
2021-06-24 5:31 ` Rocco Yue
2021-06-24 5:29 ` Greg KH
2021-06-24 6:13 ` Rocco Yue
2021-06-24 9:04 ` Greg KH
2021-06-24 12:24 ` Rocco Yue
2021-06-24 13:06 ` Greg KH
2021-06-25 6:01 ` Rocco Yue
2021-06-24 16:14 ` Dan Williams
2021-06-25 6:04 ` Rocco Yue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210624033353.25636-1-rocco.yue@mediatek.com \
--to=rocco.yue@mediatek.com \
--cc=Mark-MC.Lee@mediatek.com \
--cc=bpf@vger.kernel.org \
--cc=chao.song@mediatek.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=john@phrozen.org \
--cc=kuba@kernel.org \
--cc=kuohong.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=sean.wang@mediatek.com \
--cc=wsd_upstream@mediatek.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).