From: James Clark <james.clark@arm.com>
To: acme@kernel.org, linux-perf-users@vger.kernel.org,
f.fainelli@gmail.com, irogers@google.com
Cc: James Clark <james.clark@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Thomas Richter <tmricht@linux.ibm.com>,
Sumanth Korikkar <sumanthk@linux.ibm.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
bpf@vger.kernel.org
Subject: [PATCH 0/3] Fix various bash constructs in tests
Date: Thu, 28 Oct 2021 14:48:24 +0100 [thread overview]
Message-ID: <20211028134828.65774-1-james.clark@arm.com> (raw)
These tests were either failing or printing warnings on my Ubuntu 18
and 20 systems. I'm not sure if there is a system where /bin/sh allows
bash constructs, or perf invokes bash instead of sh, but I saw that
there have been similar fixes made in the past so I assume this should
be done.
Adding set -e to the scripts didn't highlight these issues, so I didn't
do it at this time.
For stat_bpf_counters.sh, there are further bashisms after the skip,
but I couldn't get BPF working, so I only fixed it up to that point.
Applies to perf/core 624ff63abfd36
James Clark (3):
perf test: Remove bash construct from stat_bpf_counters.sh test
perf tests: Remove bash construct from record+zstd_comp_decomp.sh
perf tests: Remove bash constructs from stat_all_pmu.sh
tools/perf/tests/shell/record+zstd_comp_decomp.sh | 2 +-
tools/perf/tests/shell/stat_all_pmu.sh | 4 ++--
tools/perf/tests/shell/stat_bpf_counters.sh | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
--
2.28.0
next reply other threads:[~2021-10-28 13:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 13:48 James Clark [this message]
2021-10-28 13:48 ` [PATCH 1/3] perf test: Remove bash construct from stat_bpf_counters.sh test James Clark
2021-10-28 13:48 ` [PATCH 2/3] perf tests: Remove bash construct from record+zstd_comp_decomp.sh James Clark
2021-10-28 13:48 ` [PATCH 3/3] perf tests: Remove bash constructs from stat_all_pmu.sh James Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211028134828.65774-1-james.clark@arm.com \
--to=james.clark@arm.com \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=bpf@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=irogers@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@redhat.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=namhyung@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=sumanthk@linux.ibm.com \
--cc=tmricht@linux.ibm.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).