From: Alan Maguire <alan.maguire@oracle.com>
To: acme@kernel.org, ast@kernel.org, jolsa@kernel.org, yhs@fb.com,
andrii@kernel.org
Cc: daniel@iogearbox.net, laoar.shao@gmail.com, martin.lau@linux.dev,
song@kernel.org, john.fastabend@gmail.com, kpsingh@kernel.org,
sdf@google.com, haoluo@google.com, bpf@vger.kernel.org,
Alan Maguire <alan.maguire@oracle.com>
Subject: [RFC dwarves 0/6] Encoding function addresses using DECL_TAGs
Date: Wed, 17 May 2023 17:16:42 +0100 [thread overview]
Message-ID: <20230517161648.17582-1-alan.maguire@oracle.com> (raw)
As a means to continue the discussion in [1], which is
concerned with finding the best long-term solution to
having a BPF Type Format (BTF) representation of
functions that is usable for tracing of edge cases, this
proof-of-concept series is intended to explore one approach
to adding information to help make tracing more accurate.
A key problem today is that there is no matching from function
description to the actual instances of a function.
When that function only has one description, that is
not an issue, but if we have multiple inconsistent
static functions in different CUs such as
From kernel/irq/irqdesc.c
static ssize_t wakeup_show(struct kobject *kobj,
struct kobj_attribute *attr, char *buf)
...and from drivers/base/power/sysfs.c
static ssize_t wakeup_show(struct device *dev, struct device_attribute *attr,
char *buf);
...this becomes a problem. If I am attaching,
which do I want? And even if I know which one
I want, which instance in kallsyms is which?
This series is a proof-of-concept that supports encoding
function addresses and associating them with BTF FUNC
descriptions using BTF declaration tags.
More work would need to be done on the kernel side
to _use_ this representation, but hopefully having a
rough approach outlined will help make that more feasible.
[1] https://lore.kernel.org/bpf/ZF61j8WJls25BYTl@krava/
Alan Maguire (6):
btf_encoder: record function address and if it is local
dwarf_loader: store address in function low_pc if available
dwarf_loader: transfer low_pc info from subtroutine to its abstract
origin
btf_encoder: add "addr=0x<addr>" function declaration tag if
--btf_gen_func_addr specified
btf_encoder: store ELF function representations sorted by name _and_
address
pahole: document --btf_gen_func_addr
btf_encoder.c | 64 +++++++++++++++++++++++++++++++++++-----------
btf_encoder.h | 4 +--
dwarf_loader.c | 16 +++++++++---
dwarves.h | 3 +++
man-pages/pahole.1 | 8 ++++++
pahole.c | 12 +++++++--
6 files changed, 85 insertions(+), 22 deletions(-)
--
2.31.1
next reply other threads:[~2023-05-17 17:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 16:16 Alan Maguire [this message]
2023-05-17 16:16 ` [RFC dwarves 1/6] btf_encoder: record function address and if it is local Alan Maguire
2023-05-17 16:16 ` [RFC dwarves 2/6] dwarf_loader: store address in function low_pc if available Alan Maguire
2023-05-17 16:16 ` [RFC dwarves 3/6] dwarf_loader: transfer low_pc info from subtroutine to its abstract origin Alan Maguire
2023-05-17 16:16 ` [RFC dwarves 4/6] btf_encoder: add "addr=0x<addr>" function declaration tag if --btf_gen_func_addr specified Alan Maguire
2023-05-17 16:16 ` [RFC dwarves 5/6] btf_encoder: store ELF function representations sorted by name _and_ address Alan Maguire
2023-05-18 8:39 ` Jiri Olsa
2023-05-18 13:23 ` Alan Maguire
2023-05-18 15:20 ` Yonghong Song
2023-05-18 16:22 ` Jiri Olsa
2023-05-18 18:25 ` Yonghong Song
2023-05-19 0:23 ` Yonghong Song
2023-05-19 0:26 ` Alexei Starovoitov
2023-05-22 21:31 ` Andrii Nakryiko
2023-05-25 8:52 ` Jiri Olsa
2023-05-25 10:14 ` Alan Maguire
2023-05-25 17:29 ` Andrii Nakryiko
2023-05-17 16:16 ` [RFC dwarves 6/6] pahole: document --btf_gen_func_addr Alan Maguire
2023-05-19 9:44 ` [RFC dwarves 0/6] Encoding function addresses using DECL_TAGs Yafang Shao
2023-05-19 14:46 ` Yonghong Song
2023-05-19 15:08 ` Alan Maguire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230517161648.17582-1-alan.maguire@oracle.com \
--to=alan.maguire@oracle.com \
--cc=acme@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=laoar.shao@gmail.com \
--cc=martin.lau@linux.dev \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).