From: Hou Tao <houtao@huaweicloud.com>
To: bpf@vger.kernel.org, Martin KaFai Lau <martin.lau@linux.dev>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Andrii Nakryiko <andrii@kernel.org>, Song Liu <song@kernel.org>,
Hao Luo <haoluo@google.com>, Yonghong Song <yhs@fb.com>,
Daniel Borkmann <daniel@iogearbox.net>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@google.com>, Jiri Olsa <jolsa@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
"Paul E . McKenney" <paulmck@kernel.org>,
rcu@vger.kernel.org, houtao1@huawei.com
Subject: [RFC PATCH bpf-next v5 0/2] Handle immediate reuse in bpf memory allocator
Date: Mon, 19 Jun 2023 22:32:29 +0800 [thread overview]
Message-ID: <20230619143231.222536-1-houtao@huaweicloud.com> (raw)
From: Hou Tao <houtao1@huawei.com>
Hi,
V5 incorporates suggestions from Alexei and Paul (Big thanks for that).
The main changes includes:
*) Use per-cpu list for reusable list and freeing list to reduce lock
contention and retain numa-ware attribute
*) Use multiple RCU callback for reuse as v3 did
*) Use rcu_momentary_dyntick_idle() to reduce the peak memory footprint
Please see individual patches for more details. As ususal comments and
suggestions are always welcome.
Change Log:
v5:
* remove prepare_reuse_head and prepare_reuse_tail
* use 32 as both low_watermark and high_watermark
* use per-cpu list for reusable list and freeing list
* use multiple RCU callbacks to do object reuse
* remove *_tail for all lists
* use rcu_momentary_dyntick_idle() to shorten RCU grace period
v4: https://lore.kernel.org/bpf/20230606035310.4026145-1-houtao@huaweicloud.com/
* no kworker (Alexei)
* Use a global reusable list in bpf memory allocator (Alexei)
* Remove BPF_MA_FREE_AFTER_RCU_GP flag and do reuse-after-rcu-gp
defaultly in bpf memory allocator (Alexei)
* add benchmark results from map_perf_test (Alexei)
v3: https://lore.kernel.org/bpf/20230429101215.111262-1-houtao@huaweicloud.com/
* add BPF_MA_FREE_AFTER_RCU_GP bpf memory allocator
* Update htab memory benchmark
* move the benchmark patch to the last patch
* remove array and useless bpf_map_lookup_elem(&array, ...) in bpf
programs
* add synchronization between addition CPU and deletion CPU for
add_del_on_diff_cpu case to prevent unnecessary loop
* add the benchmark result for "extra call_rcu + bpf ma"
v2: https://lore.kernel.org/bpf/20230408141846.1878768-1-houtao@huaweicloud.com/
* add a benchmark for bpf memory allocator to compare between different
flavor of bpf memory allocator.
* implement BPF_MA_REUSE_AFTER_RCU_GP for bpf memory allocator.
v1: https://lore.kernel.org/bpf/20221230041151.1231169-1-houtao@huaweicloud.com/
Hou Tao (2):
bpf: Only reuse after one RCU GP in bpf memory allocator
bpf: Call rcu_momentary_dyntick_idle() in task work periodically
kernel/bpf/memalloc.c | 371 ++++++++++++++++++++++++++++--------------
1 file changed, 250 insertions(+), 121 deletions(-)
--
2.29.2
next reply other threads:[~2023-06-19 14:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-19 14:32 Hou Tao [this message]
2023-06-19 14:32 ` [RFC PATCH bpf-next v5 1/2] bpf: Only reuse after one RCU GP in bpf memory allocator Hou Tao
2023-06-19 14:32 ` [RFC PATCH bpf-next v5 2/2] bpf: Call rcu_momentary_dyntick_idle() in task work periodically Hou Tao
2023-06-20 16:15 ` Alexei Starovoitov
2023-06-20 17:21 ` Paul E. McKenney
2023-06-21 1:07 ` Hou Tao
2023-06-21 1:20 ` Alexei Starovoitov
2023-06-21 1:38 ` Hou Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230619143231.222536-1-houtao@huaweicloud.com \
--to=houtao@huaweicloud.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=houtao1@huawei.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=martin.lau@linux.dev \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).