From: Gavin Li <gavinl@nvidia.com>
To: <mst@redhat.com>, <jasowang@redhat.com>,
<xuanzhuo@linux.alibaba.com>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<ast@kernel.org>, <daniel@iogearbox.net>, <hawk@kernel.org>,
<john.fastabend@gmail.com>, <jiri@nvidia.com>,
<dtatulea@nvidia.com>
Cc: <gavi@nvidia.com>, <virtualization@lists.linux-foundation.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<bpf@vger.kernel.org>
Subject: [PATCH net-next V2 2/4] virtio_net: extract get/set interrupt coalesce to a function
Date: Mon, 17 Jul 2023 17:30:35 +0300 [thread overview]
Message-ID: <20230717143037.21858-3-gavinl@nvidia.com> (raw)
In-Reply-To: <20230717143037.21858-1-gavinl@nvidia.com>
Extract get/set interrupt coalesce to a function to be reused by global
and per queue config.
Signed-off-by: Gavin Li <gavinl@nvidia.com>
Reviewed-by: Dragos Tatulea <dtatulea@nvidia.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
---
drivers/net/virtio_net.c | 22 +++++++++++++++++-----
1 file changed, 17 insertions(+), 5 deletions(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index dd5fec073a27..802ed21453f5 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -3093,10 +3093,8 @@ static int virtnet_coal_params_supported(struct ethtool_coalesce *ec)
return 0;
}
-static int virtnet_set_coalesce(struct net_device *dev,
- struct ethtool_coalesce *ec,
- struct kernel_ethtool_coalesce *kernel_coal,
- struct netlink_ext_ack *extack)
+static int virtnet_set_coalesce_one(struct net_device *dev,
+ struct ethtool_coalesce *ec)
{
struct virtnet_info *vi = netdev_priv(dev);
int ret, i, napi_weight;
@@ -3127,10 +3125,16 @@ static int virtnet_set_coalesce(struct net_device *dev,
return ret;
}
-static int virtnet_get_coalesce(struct net_device *dev,
+static int virtnet_set_coalesce(struct net_device *dev,
struct ethtool_coalesce *ec,
struct kernel_ethtool_coalesce *kernel_coal,
struct netlink_ext_ack *extack)
+{
+ return virtnet_set_coalesce_one(dev, ec);
+}
+
+static int virtnet_get_coalesce_one(struct net_device *dev,
+ struct ethtool_coalesce *ec)
{
struct virtnet_info *vi = netdev_priv(dev);
@@ -3149,6 +3153,14 @@ static int virtnet_get_coalesce(struct net_device *dev,
return 0;
}
+static int virtnet_get_coalesce(struct net_device *dev,
+ struct ethtool_coalesce *ec,
+ struct kernel_ethtool_coalesce *kernel_coal,
+ struct netlink_ext_ack *extack)
+{
+ return virtnet_get_coalesce_one(dev, ec);
+}
+
static void virtnet_init_settings(struct net_device *dev)
{
struct virtnet_info *vi = netdev_priv(dev);
--
2.39.1
next prev parent reply other threads:[~2023-07-17 14:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 14:30 [PATCH net-next V2 0/4] virtio_net: add per queue interrupt coalescing support Gavin Li
2023-07-17 14:30 ` [PATCH net-next V2 1/4] virtio_net: extract interrupt coalescing settings to a structure Gavin Li
2023-07-17 14:30 ` Gavin Li [this message]
2023-07-17 14:30 ` [PATCH net-next V2 3/4] virtio_net: support per queue interrupt coalesce command Gavin Li
2023-07-17 15:22 ` Gavin Li
2023-07-18 3:29 ` Heng Qi
2023-07-18 6:28 ` Gavin Li
2023-07-18 3:37 ` Heng Qi
2023-07-18 6:45 ` Gavin Li
2023-07-19 12:19 ` Heng Qi
2023-07-17 14:30 ` [PATCH net-next V2 4/4] virtio_net: enable per queue interrupt coalesce feature Gavin Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230717143037.21858-3-gavinl@nvidia.com \
--to=gavinl@nvidia.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=gavi@nvidia.com \
--cc=hawk@kernel.org \
--cc=jasowang@redhat.com \
--cc=jiri@nvidia.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).