From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9153143683 for ; Thu, 5 Oct 2023 23:09:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="T21RCpP3" Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 283D1113 for ; Thu, 5 Oct 2023 16:08:57 -0700 (PDT) Received: by mail-yb1-xb49.google.com with SMTP id 3f1490d57ef6-d8671837a86so2140127276.3 for ; Thu, 05 Oct 2023 16:08:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1696547336; x=1697152136; darn=vger.kernel.org; h=to:from:subject:mime-version:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=6PH2cAsL7ZmGW0ga84DGnl+E4H8MGEhL8hL3s4dJUcs=; b=T21RCpP3eYpF1Yqgiz+hW69WTnb1nCUFumiP9HOcfQkSSxFmS461jvSH60mrtBY2J9 rvSpo7EsmvmG0EpHqlZmQ8c+OZys7J7UOULJmKlvOwIKBB4/hGzlVQTmhwLUPW3W1zgS N44rlyAxYQ9vaZRJbF6qmcWUQpXG9qS0FhuHvjhiqwtcQTfIWbbVrSWKoTGJ83SrlaOe z421vuGjQcAOrcy1/PxIrw/LPI4mrEIUzriSFqatk+eyKKbHWupiS/47wgU7g7cYq+48 gZVpD8CPJhY+kA3I962re7YrMSVraQm7baFGWmnZahli88krWcW+/IspZRHpIPGFCYUE dHFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696547336; x=1697152136; h=to:from:subject:mime-version:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=6PH2cAsL7ZmGW0ga84DGnl+E4H8MGEhL8hL3s4dJUcs=; b=KqFP/zGEHkM2dEQDtIEMReEIBJUyXOtcUvSYKIQbEjcJrwjALvFP3NcqyAo/iv/RV9 K2ncq/7wNJz/9CHpdy862H0Nmt1QarPAA4d9qD+rL3RKwEf6YL7xbykeeuBhWOrqG1+R AOEfMcSU8TO7q1OYa9SZtuaa9WfeHAHEYefFM2dbeoYQf/wmryRx5bqXpIfIoU4GFEY+ XCbZ0LHkM7wqC02m02bg0elR5LFPFZPA8C+JR0pu3ZHRUOt/zEbr6xWkP9JXiqZhUJPA sNEQ2BUgDbFi3VBD9VMih9D3noi71xQ5RFwM1V0aPG4QkYu6g/MqZ4VR4W/Se0H3zDYd l/oQ== X-Gm-Message-State: AOJu0YyvnKkQMSGFV+u4uDhqcv0fyxkeTDb5RAEDjVjrTvyWYSurNRc8 MIPDv854YlKg/jkdBBBWdJs8/xJCtFyx X-Google-Smtp-Source: AGHT+IGmTeCTxelDhJ6LgrAsC5ohSvy9KxR9w2zSEbYKKeER/RxN0dw/vm8Y+jDSo+tx+urMxsQIl5sLvuPE X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:7449:56a1:2b14:305b]) (user=irogers job=sendgmr) by 2002:a25:694b:0:b0:d7b:8d0c:43f0 with SMTP id e72-20020a25694b000000b00d7b8d0c43f0mr104227ybc.11.1696547336405; Thu, 05 Oct 2023 16:08:56 -0700 (PDT) Date: Thu, 5 Oct 2023 16:08:33 -0700 Message-Id: <20231005230851.3666908-1-irogers@google.com> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.42.0.609.gbb76f46606-goog Subject: [PATCH v2 00/18] clang-tools support in tools From: Ian Rogers To: Nathan Chancellor , Nick Desaulniers , Tom Rix , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Yicong Yang , Jonathan Cameron , Yang Jihong , Kan Liang , Ming Wang , Huacai Chen , Sean Christopherson , K Prateek Nayak , Yanteng Si , Yuan Can , Ravi Bangoria , James Clark , llvm@lists.linux.dev, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, bpf@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Allow the clang-tools scripts to work with builds in tools such as tools/perf and tools/lib/perf. An example use looks like: ``` $ cd tools/perf $ make CC=clang CXX=clang++ $ ../../scripts/clang-tools/gen_compile_commands.py $ ../../scripts/clang-tools/run-clang-tools.py clang-tidy compile_commands.json -checks=-*,readability-named-parameter Skipping non-C file: 'tools/perf/bench/mem-memcpy-x86-64-asm.S' Skipping non-C file: 'tools/perf/bench/mem-memset-x86-64-asm.S' Skipping non-C file: 'tools/perf/arch/x86/tests/regs_load.S' 8 warnings generated. Suppressed 8 warnings (8 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 2 warnings generated. 4 warnings generated. Suppressed 4 warnings (4 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 2 warnings generated. 4 warnings generated. Suppressed 4 warnings (4 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 3 warnings generated. tools/perf/util/parse-events-flex.c:546:27: warning: all parameters should be named in a function [readability-named-parameter] void *yyalloc ( yy_size_t , yyscan_t yyscanner ); ^ /*size*/ ... ``` Fix a number of the more serious low-hanging issues in perf found by clang-tidy. This support isn't complete, in particular it doesn't support output directories properly and so fails for tools/lib/bpf, tools/bpf/bpftool and if an output directory is used. v2: Address comments by Nick Desaulniers in patch 3, and add their Reviewed-by to patches 1 and 2. Ian Rogers (18): gen_compile_commands: Allow the line prefix to still be cmd_ gen_compile_commands: Sort output compile commands by file name run-clang-tools: Add pass through checks and and header-filter arguments perf hisi-ptt: Fix potential memory leak perf bench uprobe: Fix potential use of memory after free perf buildid-cache: Fix use of uninitialized value perf env: Remove unnecessary NULL tests perf jitdump: Avoid memory leak perf mem-events: Avoid uninitialized read perf dlfilter: Be defensive against potential NULL dereference perf hists browser: Reorder variables to reduce padding perf hists browser: Avoid potential NULL dereference perf svghelper: Avoid memory leak perf parse-events: Fix unlikely memory leak when cloning terms tools api: Avoid potential double free perf trace-event-info: Avoid passing NULL value to closedir perf header: Fix various error path memory leaks perf bpf_counter: Fix a few memory leaks scripts/clang-tools/gen_compile_commands.py | 8 +-- scripts/clang-tools/run-clang-tools.py | 32 ++++++++--- tools/lib/api/io.h | 1 + tools/perf/bench/uprobe.c | 1 + tools/perf/builtin-buildid-cache.c | 6 +- tools/perf/builtin-lock.c | 1 + tools/perf/ui/browsers/hists.c | 6 +- tools/perf/util/bpf_counter.c | 5 +- tools/perf/util/dlfilter.c | 4 +- tools/perf/util/env.c | 6 +- tools/perf/util/header.c | 63 +++++++++++++-------- tools/perf/util/hisi-ptt.c | 12 ++-- tools/perf/util/jitdump.c | 1 + tools/perf/util/mem-events.c | 3 +- tools/perf/util/parse-events.c | 4 +- tools/perf/util/svghelper.c | 5 +- tools/perf/util/trace-event-info.c | 3 +- 17 files changed, 104 insertions(+), 57 deletions(-) -- 2.42.0.609.gbb76f46606-goog