bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
To: virtualization@lists.linux.dev
Cc: "Richard Weinberger" <richard@nod.at>,
	"Anton Ivanov" <anton.ivanov@cambridgegreys.com>,
	"Johannes Berg" <johannes@sipsolutions.net>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Jason Wang" <jasowang@redhat.com>,
	"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Hans de Goede" <hdegoede@redhat.com>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Vadim Pasternak" <vadimp@nvidia.com>,
	"Bjorn Andersson" <andersson@kernel.org>,
	"Mathieu Poirier" <mathieu.poirier@linaro.org>,
	"Cornelia Huck" <cohuck@redhat.com>,
	"Halil Pasic" <pasic@linux.ibm.com>,
	"Eric Farman" <farman@linux.ibm.com>,
	"Heiko Carstens" <hca@linux.ibm.com>,
	"Vasily Gorbik" <gor@linux.ibm.com>,
	"Alexander Gordeev" <agordeev@linux.ibm.com>,
	"Christian Borntraeger" <borntraeger@linux.ibm.com>,
	"Sven Schnelle" <svens@linux.ibm.com>,
	"Alexei Starovoitov" <ast@kernel.org>,
	"Daniel Borkmann" <daniel@iogearbox.net>,
	"Jesper Dangaard Brouer" <hawk@kernel.org>,
	"John Fastabend" <john.fastabend@gmail.com>,
	"Benjamin Berg" <benjamin.berg@intel.com>,
	"Yang Li" <yang.lee@linux.alibaba.com>,
	linux-um@lists.infradead.org, netdev@vger.kernel.org,
	platform-driver-x86@vger.kernel.org,
	linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org,
	kvm@vger.kernel.org, bpf@vger.kernel.org
Subject: [PATCH vhost 00/17] virtio: drivers maintain dma info for premapped vq
Date: Tue, 30 Jan 2024 19:42:07 +0800	[thread overview]
Message-ID: <20240130114224.86536-1-xuanzhuo@linux.alibaba.com> (raw)

As discussed:
http://lore.kernel.org/all/CACGkMEvq0No8QGC46U4mGsMtuD44fD_cfLcPaVmJ3rHYqRZxYg@mail.gmail.com

If the virtio is premapped mode, the driver should manage the dma info by self.
So the virtio core should not store the dma info.
So we can release the memory used to store the dma info.

But if the desc_extra has not dma info, we face a new question,
it is hard to get the dma info of the desc with indirect flag.
For split mode, that is easy from desc, but for the packed mode,
it is hard to get the dma info from the desc. And for hardening
the dma unmap is saft, we should store the dma info of indirect
descs.

So I introduce the "structure the indirect desc table" to
allocate space to store dma info with the desc table.

On the other side, we mix the descs with indirect flag
with other descs together to share the unmap api. That
is complex. I found if we we distinguish the descs with
VRING_DESC_F_INDIRECT before unmap, thing will be clearer.

Because of the dma array is allocated in the find_vqs(),
so I introduce a new parameter to find_vqs().

Please review.

Thanks

Xuan Zhuo (17):
  virtio_ring: introduce vring_need_unmap_buffer
  virtio_ring: packed: remove double check of the unmap ops
  virtio_ring: packed: structure the indirect desc table
  virtio_ring: split: remove double check of the unmap ops
  virtio_ring: split: structure the indirect desc table
  virtio_ring: no store dma info when unmap is not needed
  virtio: find_vqs: pass struct instead of multi parameters
  virtio: vring_new_virtqueue(): pass struct instead of multi parameters
  virtio_ring: reuse the parameter struct of find_vqs()
  virtio: find_vqs: add new parameter premapped
  virtio_ring: export premapped to driver by struct virtqueue
  virtio_net: set premapped mode by find_vqs()
  virtio_ring: remove api of setting vq premapped
  virtio_ring: introduce dma map api for page
  virtio_net: unify the code for recycling the xmit ptr
  virtio_net: rename free_old_xmit_skbs to free_old_xmit
  virtio_net: sq support premapped mode

 arch/um/drivers/virtio_uml.c             |  29 +-
 drivers/net/virtio_net.c                 | 298 +++++++---
 drivers/platform/mellanox/mlxbf-tmfifo.c |  24 +-
 drivers/remoteproc/remoteproc_virtio.c   |  31 +-
 drivers/s390/virtio/virtio_ccw.c         |  33 +-
 drivers/virtio/virtio_mmio.c             |  30 +-
 drivers/virtio/virtio_pci_common.c       |  59 +-
 drivers/virtio/virtio_pci_common.h       |   9 +-
 drivers/virtio/virtio_pci_legacy.c       |  16 +-
 drivers/virtio/virtio_pci_modern.c       |  24 +-
 drivers/virtio/virtio_ring.c             | 660 ++++++++++++-----------
 drivers/virtio/virtio_vdpa.c             |  33 +-
 include/linux/virtio.h                   |  10 +-
 include/linux/virtio_config.h            |  48 +-
 include/linux/virtio_ring.h              |  82 +--
 tools/virtio/virtio_test.c               |   4 +-
 tools/virtio/vringh_test.c               |  32 +-
 17 files changed, 812 insertions(+), 610 deletions(-)

--
2.32.0.3.g01195cf9f


             reply	other threads:[~2024-01-30 11:42 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-30 11:42 Xuan Zhuo [this message]
2024-01-30 11:42 ` [PATCH vhost 01/17] virtio_ring: introduce vring_need_unmap_buffer Xuan Zhuo
2024-01-31  9:12   ` Jason Wang
2024-01-30 11:42 ` [PATCH vhost 02/17] virtio_ring: packed: remove double check of the unmap ops Xuan Zhuo
2024-01-31  9:12   ` Jason Wang
2024-01-31  9:58     ` Xuan Zhuo
2024-01-30 11:42 ` [PATCH vhost 03/17] virtio_ring: packed: structure the indirect desc table Xuan Zhuo
2024-01-31  9:12   ` Jason Wang
2024-01-31 10:00     ` Xuan Zhuo
2024-02-01  0:41       ` Jason Wang
2024-01-30 11:42 ` [PATCH vhost 04/17] virtio_ring: split: remove double check of the unmap ops Xuan Zhuo
2024-01-31  9:12   ` Jason Wang
2024-01-31  9:43     ` Michael S. Tsirkin
2024-02-01  5:47       ` Jason Wang
2024-02-01  6:43     ` Xuan Zhuo
2024-01-30 11:42 ` [PATCH vhost 05/17] virtio_ring: split: structure the indirect desc table Xuan Zhuo
2024-01-31  9:12   ` Jason Wang
2024-01-30 11:42 ` [PATCH vhost 06/17] virtio_ring: no store dma info when unmap is not needed Xuan Zhuo
2024-01-31  9:12   ` Jason Wang
2024-02-01  6:04     ` Xuan Zhuo
2024-02-02  3:04       ` Jason Wang
2024-01-30 11:42 ` [PATCH vhost 07/17] virtio: find_vqs: pass struct instead of multi parameters Xuan Zhuo
2024-01-31  9:12   ` Jason Wang
2024-02-01  3:00     ` Xuan Zhuo
2024-02-20 14:18       ` Halil Pasic
2024-02-21  2:03         ` Xuan Zhuo
2024-01-30 11:42 ` [PATCH vhost 08/17] virtio: vring_new_virtqueue(): " Xuan Zhuo
2024-01-31  9:12   ` Jason Wang
2024-01-31 11:03   ` Ilpo Järvinen
2024-02-01  2:24     ` Xuan Zhuo
2024-01-30 11:42 ` [PATCH vhost 09/17] virtio_ring: reuse the parameter struct of find_vqs() Xuan Zhuo
2024-01-30 11:42 ` [PATCH vhost 10/17] virtio: find_vqs: add new parameter premapped Xuan Zhuo
2024-01-30 11:42 ` [PATCH vhost 11/17] virtio_ring: export premapped to driver by struct virtqueue Xuan Zhuo
2024-01-31  9:12   ` Jason Wang
2024-02-01  3:17     ` Xuan Zhuo
2024-01-30 11:42 ` [PATCH vhost 12/17] virtio_net: set premapped mode by find_vqs() Xuan Zhuo
2024-01-30 11:42 ` [PATCH vhost 13/17] virtio_ring: remove api of setting vq premapped Xuan Zhuo
2024-01-30 11:42 ` [PATCH vhost 14/17] virtio_ring: introduce dma map api for page Xuan Zhuo
2024-01-30 11:42 ` [PATCH vhost 15/17] virtio_net: unify the code for recycling the xmit ptr Xuan Zhuo
2024-01-30 11:42 ` [PATCH vhost 16/17] virtio_net: rename free_old_xmit_skbs to free_old_xmit Xuan Zhuo
2024-01-30 11:42 ` [PATCH vhost 17/17] virtio_net: sq support premapped mode Xuan Zhuo
2024-01-31  9:12   ` Jason Wang
2024-02-01  3:21     ` Xuan Zhuo
2024-02-01  5:36       ` Jason Wang
2024-02-01  5:56         ` Xuan Zhuo
2024-02-02  3:06           ` Jason Wang
2024-02-01  7:43 ` [PATCH vhost 00/17] virtio: drivers maintain dma info for premapped vq Zhu Yanjun
2024-02-01  9:57   ` Xuan Zhuo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240130114224.86536-1-xuanzhuo@linux.alibaba.com \
    --to=xuanzhuo@linux.alibaba.com \
    --cc=agordeev@linux.ibm.com \
    --cc=andersson@kernel.org \
    --cc=anton.ivanov@cambridgegreys.com \
    --cc=ast@kernel.org \
    --cc=benjamin.berg@intel.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=bpf@vger.kernel.org \
    --cc=cohuck@redhat.com \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=farman@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hawk@kernel.org \
    --cc=hca@linux.ibm.com \
    --cc=hdegoede@redhat.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jasowang@redhat.com \
    --cc=johannes@sipsolutions.net \
    --cc=john.fastabend@gmail.com \
    --cc=kuba@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux-um@lists.infradead.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pasic@linux.ibm.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=richard@nod.at \
    --cc=svens@linux.ibm.com \
    --cc=vadimp@nvidia.com \
    --cc=virtualization@lists.linux.dev \
    --cc=yang.lee@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).