From: Yafang Shao <laoar.shao@gmail.com>
To: ast@kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com,
andrii@kernel.org, martin.lau@linux.dev, song@kernel.org,
yonghong.song@linux.dev, kpsingh@kernel.org, sdf@google.com,
haoluo@google.com, jolsa@kernel.org, tj@kernel.org,
void@manifault.com
Cc: bpf@vger.kernel.org, Yafang Shao <laoar.shao@gmail.com>
Subject: [PATCH v5 bpf-next 0/4] bpf: Add bpf_iter_cpumask
Date: Wed, 31 Jan 2024 22:54:50 +0800 [thread overview]
Message-ID: <20240131145454.86990-1-laoar.shao@gmail.com> (raw)
Three new kfuncs, namely bpf_iter_cpumask_{new,next,destroy}, have been
added for the new bpf_iter_cpumask functionality. These kfuncs enable the
iteration of percpu data, such as runqueues, system_group_pcpu, and more.
In our specific use case, we leverage the cgroup iterator to traverse
percpu data, subsequently exposing it to userspace through a seq file.
Refer to example in patch #2 for the usage.
Changes:
- v4 -> v5:
- Use cpumask_size() instead of sizeof(struct cpumask) (David)
- Refactor the selftests as suggsted by David
- Improve the doc as suggested by David
- v3 -> v4:
- Use a copy of cpumask to avoid potential use-after-free (Yonghong)
- Various code improvement in selftests (Yonghong)
- v2 -> v3:
- Define KF_RCU_PROTECTED for bpf_iter_cpumask_new (Alexei)
- Code improvement in selftests
- Fix build error in selftest due to CONFIG_PSI=n
reported by kernel test robot <lkp@intel.com>
- v1 -> v2:
- Avoid changing cgroup subsystem (Tejun)
- Remove bpf_cpumask_set_from_pid(), and use bpf_cpumask_copy()
instead (Tejun)
- Use `int cpu;` field in bpf_iter_cpumask_kern (Andrii)
- bpf: Add new bpf helper bpf_for_each_cpu
https://lwn.net/ml/bpf/20230801142912.55078-1-laoar.shao@gmail.com/
Yafang Shao (4):
bpf: Add bpf_iter_cpumask kfuncs
bpf, docs: Add document for cpumask iter
selftests/bpf: Fix error checking for cpumask_success__load()
selftests/bpf: Add selftests for cpumask iter
Documentation/bpf/cpumasks.rst | 60 +++++++
kernel/bpf/cpumask.c | 82 +++++++++
tools/testing/selftests/bpf/config | 1 +
.../selftests/bpf/prog_tests/cpumask.c | 158 +++++++++++++++++-
.../selftests/bpf/progs/cpumask_common.h | 3 +
.../bpf/progs/cpumask_iter_failure.c | 99 +++++++++++
.../bpf/progs/cpumask_iter_success.c | 126 ++++++++++++++
7 files changed, 526 insertions(+), 3 deletions(-)
create mode 100644 tools/testing/selftests/bpf/progs/cpumask_iter_failure.c
create mode 100644 tools/testing/selftests/bpf/progs/cpumask_iter_success.c
--
2.39.1
next reply other threads:[~2024-01-31 14:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 14:54 Yafang Shao [this message]
2024-01-31 14:54 ` [PATCH v5 bpf-next 1/4] bpf: Add bpf_iter_cpumask kfuncs Yafang Shao
2024-02-02 22:02 ` Andrii Nakryiko
2024-02-04 3:31 ` Yafang Shao
2024-01-31 14:54 ` [PATCH v5 bpf-next 2/4] bpf, docs: Add document for cpumask iter Yafang Shao
2024-02-02 22:02 ` Andrii Nakryiko
2024-01-31 14:54 ` [PATCH v5 bpf-next 3/4] selftests/bpf: Fix error checking for cpumask_success__load() Yafang Shao
2024-02-02 22:03 ` Andrii Nakryiko
2024-01-31 14:54 ` [PATCH v5 bpf-next 4/4] selftests/bpf: Add selftests for cpumask iter Yafang Shao
2024-02-02 22:02 ` Andrii Nakryiko
2024-02-04 3:30 ` Yafang Shao
2024-02-04 17:09 ` Yonghong Song
2024-02-05 2:49 ` Yafang Shao
2024-02-05 18:25 ` Andrii Nakryiko
2024-02-06 7:38 ` Yafang Shao
2024-02-05 3:08 ` kernel test robot
2024-02-05 13:14 ` Yafang Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240131145454.86990-1-laoar.shao@gmail.com \
--to=laoar.shao@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=martin.lau@linux.dev \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=tj@kernel.org \
--cc=void@manifault.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).