bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: John Fastabend <john.fastabend@gmail.com>
Cc: stable@vger.kernel.org, bpf@vger.kernel.org,
	daniel@iogearbox.net, dhowells@redhat.com, kuba@kernel.org
Subject: Re: [PATCH stable, 6.1 1/2] tcp_bpf: Inline do_tcp_sendpages as it's now a wrapper around tcp_sendmsg
Date: Wed, 15 May 2024 09:30:25 +0200	[thread overview]
Message-ID: <2024051500-underage-unfixed-5d28@gregkh> (raw)
In-Reply-To: <20240507174757.260478-2-john.fastabend@gmail.com>

On Tue, May 07, 2024 at 10:47:56AM -0700, John Fastabend wrote:
> From: David Howells <dhowells@redhat.com>
> 
> [ Upstream commit ebf2e8860eea66e2c4764316b80c6a5ee5f336ee ]
> 
> do_tcp_sendpages() is now just a small wrapper around tcp_sendmsg_locked(),
> so inline it.  This is part of replacing ->sendpage() with a call to
> sendmsg() with MSG_SPLICE_PAGES set.
> 
> Fixes: 04919bed948dc ("tcp: Introduce tcp_read_skb()")
> Signed-off-by: David Howells <dhowells@redhat.com>
> cc: John Fastabend <john.fastabend@gmail.com>
> cc: Jakub Sitnicki <jakub@cloudflare.com>
> cc: David Ahern <dsahern@kernel.org>
> cc: Jens Axboe <axboe@kernel.dk>
> cc: Matthew Wilcox <willy@infradead.org>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
>  net/ipv4/tcp_bpf.c | 20 ++++++++++++--------
>  1 file changed, 12 insertions(+), 8 deletions(-)

You too need to sign off on a patch you forward to someone else, that's
what the DCO means :)

Please fix up and resend.

thanks,

greg k-h

  reply	other threads:[~2024-05-15  7:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-07 17:47 [PATCH stable, 6.1 0/2] Fix for sockmap causing data stalls John Fastabend
2024-05-07 17:47 ` [PATCH stable, 6.1 1/2] tcp_bpf: Inline do_tcp_sendpages as it's now a wrapper around tcp_sendmsg John Fastabend
2024-05-15  7:30   ` Greg KH [this message]
2024-05-07 17:47 ` [PATCH stable, 6.1 2/2] tcp_bpf, smc, tls, espintcp, siw: Reduce MSG_SENDPAGE_NOTLAST usage John Fastabend

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024051500-underage-unfixed-5d28@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=dhowells@redhat.com \
    --cc=john.fastabend@gmail.com \
    --cc=kuba@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).