bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
To: Felix Kuehling <felix.kuehling@amd.com>,
	Waiman Long <longman@redhat.com>,
	edumazet@google.com, jakub@cloudflare.com
Cc: syzkaller-bugs@googlegroups.com, netdev@vger.kernel.org,
	syzbot <syzbot+94cc2a66fc228b23f360@syzkaller.appspotmail.com>,
	Alexander.Deucher@amd.com, Christian.Koenig@amd.com,
	David1.Zhou@amd.com, Evan.Quan@amd.com, Harry.Wentland@amd.com,
	Oak.Zeng@amd.com, Ray.Huang@amd.com, Yong.Zhao@amd.com,
	airlied@linux.ie, ast@kernel.org, boqun.feng@gmail.com,
	daniel@ffwll.ch, daniel@iogearbox.net, davem@davemloft.net,
	dsahern@kernel.org, gautammenghani201@gmail.com, kafai@fb.com,
	kuba@kernel.org, kuznet@ms2.inr.ac.ru, mingo@redhat.com,
	ozeng@amd.com, pabeni@redhat.com, peterz@infradead.org,
	rex.zhu@amd.com, songliubraving@fb.com, will@kernel.org,
	yhs@fb.com, yoshfuji@linux-ipv6.org
Subject: Re: [syzbot] WARNING: locking bug in inet_autobind
Date: Wed, 4 Jan 2023 07:07:45 +0900	[thread overview]
Message-ID: <2b35515e-5ad0-ee84-c90f-cb61428be4e4@I-love.SAKURA.ne.jp> (raw)
In-Reply-To: <a47b840f-b2b8-95d7-ddc0-c9d5dde3c28c@amd.com>

On 2023/01/04 1:20, Felix Kuehling wrote:
> 
> Am 2023-01-03 um 11:05 schrieb Waiman Long:
>> On 1/3/23 10:39, Felix Kuehling wrote:
>>> The regression point doesn't make sense. The kernel config doesn't enable CONFIG_DRM_AMDGPU, so there is no way that a change in AMDGPU could have caused this regression.
>>>
>> I agree. It is likely a pre-existing problem or caused by another commit that got triggered because of the change in cacheline alignment caused by commit c0d9271ecbd ("drm/amdgpu: Delete user queue doorbell variable").
> I don't think the change can affect cache line alignment. The entire amdgpu driver doesn't even get compiled in the kernel config that was used, and the change doesn't touch any files outside drivers/gpu/drm/amd/amdgpu:
> 
> # CONFIG_DRM_AMDGPU is not set
> 
> My guess would be that it's an intermittent bug that is confusing bisect.
> 
> Regards,
>   Felix

This was already explained in https://groups.google.com/g/syzkaller-bugs/c/1rmGDmbXWIw/m/nIQm0EmxBAAJ .

Jakub Sitnicki suggested

  What if we revisit Eric's lockdep splat fix in 37159ef2c1ae ("l2tp: fix
  a lockdep splat") and: 

  1. remove the lockdep_set_class_and_name(...) call in l2tp; it looks
     like an odd case within the network stack, and

  2. switch to bh_lock_sock_nested in l2tp_xmit_core so that we don't
     break what has been fixed in 37159ef2c1ae.

and we are waiting for response from Eric Dumazet.


      reply	other threads:[~2023-01-03 22:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-16  5:46 WARNING: locking bug in inet_autobind syzbot
2019-05-21  8:31 ` syzbot
2019-05-22  3:16 ` syzbot
2022-09-18 15:52 ` Tetsuo Handa
2022-12-29  6:26 ` [syzbot] " syzbot
2023-01-03 15:39   ` Felix Kuehling
2023-01-03 16:05     ` Waiman Long
2023-01-03 16:20       ` Felix Kuehling
2023-01-03 22:07         ` Tetsuo Handa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b35515e-5ad0-ee84-c90f-cb61428be4e4@I-love.SAKURA.ne.jp \
    --to=penguin-kernel@i-love.sakura.ne.jp \
    --cc=Alexander.Deucher@amd.com \
    --cc=Christian.Koenig@amd.com \
    --cc=David1.Zhou@amd.com \
    --cc=Evan.Quan@amd.com \
    --cc=Harry.Wentland@amd.com \
    --cc=Oak.Zeng@amd.com \
    --cc=Ray.Huang@amd.com \
    --cc=Yong.Zhao@amd.com \
    --cc=airlied@linux.ie \
    --cc=ast@kernel.org \
    --cc=boqun.feng@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=felix.kuehling@amd.com \
    --cc=gautammenghani201@gmail.com \
    --cc=jakub@cloudflare.com \
    --cc=kafai@fb.com \
    --cc=kuba@kernel.org \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=longman@redhat.com \
    --cc=mingo@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=ozeng@amd.com \
    --cc=pabeni@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rex.zhu@amd.com \
    --cc=songliubraving@fb.com \
    --cc=syzbot+94cc2a66fc228b23f360@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=will@kernel.org \
    --cc=yhs@fb.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).