From: Daniel Borkmann <daniel@iogearbox.net>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Martynas Pumputis <m@lambda.lt>, Joe Stringer <joe@wand.net.nz>,
bpf <bpf@vger.kernel.org>, Networking <netdev@vger.kernel.org>
Subject: Re: [PATCH bpf-next 4/7] bpf: allow to retrieve cgroup v1 classid from v2 hooks
Date: Sat, 28 Mar 2020 02:56:37 +0100 [thread overview]
Message-ID: <3e519e0e-aa52-67a5-98f6-0e259745e400@iogearbox.net> (raw)
In-Reply-To: <CAEf4BzY5dd-wXbLziCQJOgikY-qvD+GQC=9HHZGCqmM_R-2mJA@mail.gmail.com>
On 3/28/20 1:41 AM, Andrii Nakryiko wrote:
> On Fri, Mar 27, 2020 at 9:00 AM Daniel Borkmann <daniel@iogearbox.net> wrote:
>>
>> Today, Kubernetes is still operating on cgroups v1, however, it is
>> possible to retrieve the task's classid based on 'current' out of
>> connect(), sendmsg(), recvmsg() and bind-related hooks for orchestrators
>> which attach to the root cgroup v2 hook in a mixed env like in case
>> of Cilium, for example, in order to then correlate certain pod traffic
>> and use it as part of the key for BPF map lookups.
>
> Have you tried getting this classid directly from task_struct in your
> BPF program with vmlinux.h and CO-RE? Seems like it should be pretty
> straightforward and not requiring a special BPF handler just for that?
To answer both questions (5/7 and this one) in the same mail here: my
understanding is that this would require to install additional tracing
programs on these hooks instead of being able to integrate them into [0]
for usage out of sock_addr and sock progs (similar as they are available
as well from tc from skb)?
Thanks,
Daniel
[0] https://github.com/cilium/cilium/blob/master/bpf/bpf_sock.c
next prev parent reply other threads:[~2020-03-28 1:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 15:58 [PATCH bpf-next 0/7] Various improvements to cgroup helpers Daniel Borkmann
2020-03-27 15:58 ` [PATCH bpf-next 1/7] bpf: enable retrieval of socket cookie for bind/post-bind hook Daniel Borkmann
2020-03-27 15:58 ` [PATCH bpf-next 2/7] bpf: enable perf event rb output for bpf cgroup progs Daniel Borkmann
2020-03-27 15:58 ` [PATCH bpf-next 3/7] bpf: add netns cookie and enable it for bpf cgroup hooks Daniel Borkmann
2020-03-28 0:32 ` Andrii Nakryiko
2020-03-28 1:30 ` Daniel Borkmann
2020-03-28 1:48 ` Alexei Starovoitov
2020-03-28 2:16 ` Daniel Borkmann
2020-03-28 2:56 ` Alexei Starovoitov
2020-03-27 15:58 ` [PATCH bpf-next 4/7] bpf: allow to retrieve cgroup v1 classid from v2 hooks Daniel Borkmann
2020-03-28 0:41 ` Andrii Nakryiko
2020-03-28 1:56 ` Daniel Borkmann [this message]
2020-03-28 20:27 ` Andrii Nakryiko
2020-03-27 15:58 ` [PATCH bpf-next 5/7] bpf: enable bpf cgroup hooks to retrieve cgroup v2 and ancestor id Daniel Borkmann
2020-03-28 0:43 ` Andrii Nakryiko
2020-03-27 15:58 ` [PATCH bpf-next 6/7] bpf: enable retrival of pid/tgid/comm from bpf cgroup hooks Daniel Borkmann
2020-03-28 0:49 ` Andrii Nakryiko
2020-03-28 1:40 ` Daniel Borkmann
2020-03-27 15:58 ` [PATCH bpf-next 7/7] bpf: add selftest cases for ctx_or_null argument type Daniel Borkmann
2020-03-28 0:51 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e519e0e-aa52-67a5-98f6-0e259745e400@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=joe@wand.net.nz \
--cc=m@lambda.lt \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).