bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ilya Leoshkevich <iii@linux.ibm.com>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org, lmb@cloudflare.com,
	gor@linux.ibm.com, heiko.carstens@de.ibm.com
Subject: Re: [PATCH bpf] tools/bpf: fix bpftool build with OUTPUT set
Date: Fri, 19 Jul 2019 15:12:24 +0200	[thread overview]
Message-ID: <43FB794B-6200-4560-BF10-BBF4B9247913@linux.ibm.com> (raw)
In-Reply-To: <20190718115111.643027cf@cakuba.netronome.com>

> Am 18.07.2019 um 20:51 schrieb Jakub Kicinski <jakub.kicinski@netronome.com>:
> 
> We should probably make a script with all the ways of calling make
> should work. Otherwise we can lose track too easily.

Thanks for the script!

I’m trying to make it all pass now, and hitting a weird issue in the
Kbuild case. The build prints "No rule to make target
'scripts/Makefile.ubsan.o'" and proceeds with an empty BPFTOOL_VERSION,
which causes problems later on.

I've found that this is caused by sub_make_done=1 environment variable,
and unsetting it indeed fixes the problem, since the root Makefile no
longer uses the implicit %.o rule.

However, I wonder if that would be acceptable in the final version of
the patch, and whether there is a cleaner way to achieve the same
effect?

Best regards,
Ilya

  reply	other threads:[~2019-07-19 13:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-18 13:59 Building bpftool with OUTPUT set breaks Lorenz Bauer
2019-07-18 14:20 ` [PATCH bpf] tools/bpf: fix bpftool build with OUTPUT set Ilya Leoshkevich
2019-07-18 18:51   ` Jakub Kicinski
2019-07-19 13:12     ` Ilya Leoshkevich [this message]
2019-07-19 18:17       ` Jakub Kicinski
2019-07-23 15:14         ` Ilya Leoshkevich
2019-07-23 12:59   ` Lorenz Bauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43FB794B-6200-4560-BF10-BBF4B9247913@linux.ibm.com \
    --to=iii@linux.ibm.com \
    --cc=bpf@vger.kernel.org \
    --cc=gor@linux.ibm.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=jakub.kicinski@netronome.com \
    --cc=lmb@cloudflare.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).