bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Fastabend <john.fastabend@gmail.com>
To: "Daniel T. Lee" <danieltimlee@gmail.com>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Alexei Starovoitov <ast@kernel.org>
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org
Subject: RE: [PATCH,bpf-next 0/2] Fix broken samples due to symbol mismatch
Date: Mon, 25 Nov 2019 10:42:54 -0800	[thread overview]
Message-ID: <5ddc20aedc82d_2b082aba75a825b4f4@john-XPS-13-9370.notmuch> (raw)
In-Reply-To: <20191123055151.9990-1-danieltimlee@gmail.com>

Daniel T. Lee wrote:
> Currently, there are broken samples due to symbol mismatch (missing or
> unused symbols). For example, the function open() calls the syscall 
> 'sys_openat' instead of 'sys_open'. And there are no exact symbols such
> as 'sys_read' or 'sys_write' under kallsyms, instead the symbols have
> prefixes. And these error leads to broke of samples.
> 
> This Patchset fixes the problem by changing the symbol match.
> 
> Daniel T. Lee (2):
>   samples: bpf: replace symbol compare of trace_event
>   samples: bpf: fix syscall_tp due to unused syscall
> 
>  samples/bpf/syscall_tp_kern.c  | 14 ++++++++++++++
>  samples/bpf/trace_event_user.c |  4 ++--
>  2 files changed, 16 insertions(+), 2 deletions(-)
> 
> -- 
> 2.24.0
> 

Patches look good, please reply to each with a "Fixes" tag
though so its easier to keep track of these things.

Thanks,
John

      parent reply	other threads:[~2019-11-25 18:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-23  5:51 [PATCH,bpf-next 0/2] Fix broken samples due to symbol mismatch Daniel T. Lee
2019-11-23  5:51 ` [PATCH,bpf-next 1/2] samples: bpf: replace symbol compare of trace_event Daniel T. Lee
2019-11-23  5:51 ` [PATCH,bpf-next 2/2] samples: bpf: fix syscall_tp due to unused syscall Daniel T. Lee
2019-11-25 23:11   ` Daniel Borkmann
2019-11-25 18:42 ` John Fastabend [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ddc20aedc82d_2b082aba75a825b4f4@john-XPS-13-9370.notmuch \
    --to=john.fastabend@gmail.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=danieltimlee@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).