bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Fastabend <john.fastabend@gmail.com>
To: Florian Lehner <dev@der-flo.net>, john.fastabend@gmail.com
Cc: ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net,
	dev@der-flo.net
Subject: RE: [PATCH bpf-next v2] bpf: Lift hashtab key_size limit
Date: Wed, 14 Oct 2020 21:21:56 -0700	[thread overview]
Message-ID: <5f87ce648edd5_b7602085a@john-XPS-13-9370.notmuch> (raw)
In-Reply-To: <20201013144515.298647-1-dev@der-flo.net>

Florian Lehner wrote:
> John Fastabend wrote:
> > I think this is OK, but just curious is there a real use-case
> > that has keys bigger than stack size or is this just an
> > in-theory observation.
> 
> The use-case for this patch originates to implement allow/disallow
> lists for files and file paths. The maximum length of file paths is
> defined by PATH_MAX with 4096 chars including nul.
> This limit exceeds MAX_BPF_STACK. 
> 
> Thanks,
>  Florian

OK the check appears unnecessary. It seems a bit excessive to have
such large keys though.

Daniel, Alexei I couldn't find this patch in patchworks, not sure
where it went.

Acked-by: John Fastabend <john.fastabend@gmail.com>

  parent reply	other threads:[~2020-10-15  4:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-22 19:02 [PATCH bpf-next v2] bpf: Lift hashtab key_size limit Florian Lehner
2020-10-12 19:45 ` John Fastabend
2020-10-14 19:25   ` Florian Lehner
     [not found] ` <20201013144515.298647-1-dev@der-flo.net>
2020-10-15  4:21   ` John Fastabend [this message]
2020-10-23 16:35     ` Florian Lehner
2020-10-23 20:27       ` Andrii Nakryiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5f87ce648edd5_b7602085a@john-XPS-13-9370.notmuch \
    --to=john.fastabend@gmail.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=dev@der-flo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).