From: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: linux-kselftest@vger.kernel.org, netdev@vger.kernel.org,
bpf@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests/bpf: fix warning comparing pointer to 0
Date: Thu, 22 Apr 2021 16:09:45 +0800 [thread overview]
Message-ID: <745a3bff-6b0e-f707-ffb5-d9f24063b57d@linux.alibaba.com> (raw)
In-Reply-To: <4983305a-3119-bb4b-bb51-520ed5bd28ac@iogearbox.net>
On 2021/3/19 0:23, Daniel Borkmann wrote:
> On 3/18/21 2:55 AM, Jiapeng Chong wrote:
>> Fix the following coccicheck warning:
>>
>> ./tools/testing/selftests/bpf/progs/fentry_test.c:76:15-16: WARNING
>> comparing pointer to 0.
>>
>> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
>> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
>> ---
>> tools/testing/selftests/bpf/progs/fentry_test.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/testing/selftests/bpf/progs/fentry_test.c
>> b/tools/testing/selftests/bpf/progs/fentry_test.c
>> index 5f645fd..d4247d6 100644
>> --- a/tools/testing/selftests/bpf/progs/fentry_test.c
>> +++ b/tools/testing/selftests/bpf/progs/fentry_test.c
>> @@ -64,7 +64,7 @@ struct bpf_fentry_test_t {
>> SEC("fentry/bpf_fentry_test7")
>> int BPF_PROG(test7, struct bpf_fentry_test_t *arg)
>> {
>> - if (arg == 0)
>> + if (!arg)
>> test7_result = 1;
>> return 0;
>> }
>> @@ -73,7 +73,7 @@ int BPF_PROG(test7, struct bpf_fentry_test_t *arg)
>> SEC("fentry/bpf_fentry_test8")
>> int BPF_PROG(test8, struct bpf_fentry_test_t *arg)
>> {
>> - if (arg->a == 0)
>> + if (!arg->a)
>> test8_result = 1;
>> return 0;
>> }
>>
>
> This doesn't apply. Please rebase against bpf-next tree, and also make
> sure to
> squash any other such patches into a single one.
OK, I'll submit it to the latest branch bpf-next tree later.
next prev parent reply other threads:[~2021-04-22 8:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 1:55 [PATCH] selftests/bpf: fix warning comparing pointer to 0 Jiapeng Chong
2021-03-18 16:23 ` Daniel Borkmann
2021-04-22 8:09 ` Jiapeng Chong [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-03-24 2:08 [PATCH] selftests/bpf: Fix " Haowen Bai
2022-03-24 20:28 ` Martin KaFai Lau
2022-03-25 19:55 ` Shuah Khan
2021-04-22 10:00 [PATCH] selftests/bpf: fix " Jiapeng Chong
2021-04-22 21:56 ` Daniel Borkmann
2021-04-23 11:57 ` Abaci Robot
2021-04-23 16:47 ` Alexei Starovoitov
2021-03-16 7:59 Jiapeng Chong
2021-03-16 23:00 ` patchwork-bot+netdevbpf
2021-03-10 6:22 Jiapeng Chong
2021-03-10 9:31 ` Yauheni Kaliuta
2021-03-10 22:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=745a3bff-6b0e-f707-ffb5-d9f24063b57d@linux.alibaba.com \
--to=jiapeng.chong@linux.alibaba.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).