From: Daniel Borkmann <daniel@iogearbox.net>
To: Jerry Cruntime <jerry.c.t@web.de>, bpf@vger.kernel.org
Subject: Re: [PATCH bpf] libbpf: Fix register in PT_REGS MIPS macros
Date: Fri, 31 Jul 2020 01:00:11 +0200 [thread overview]
Message-ID: <76288d74-3110-952a-f068-e040d63dbd7d@iogearbox.net> (raw)
In-Reply-To: <05fb9d72-d1a7-5346-b55b-4495cdf54124@web.de>
On 7/30/20 1:44 PM, Jerry Cruntime wrote:
> The o32, n32 and n64 calling conventions require the return
> value to be stored in $v0 which maps to $2 register, i.e.,
> the second register.
>
> Fixes: c1932cd ("bpf: Add MIPS support to samples/bpf.")
Jerry, your patch is missing a Signed-off-by from you. It should be enough if
you just reply with one in here that I'll add to the commit message and I'll
take it via bpf tree then, thanks.
> ---
> tools/lib/bpf/bpf_tracing.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/lib/bpf/bpf_tracing.h b/tools/lib/bpf/bpf_tracing.h
> index 58eceb884..ae205dcf8 100644
> --- a/tools/lib/bpf/bpf_tracing.h
> +++ b/tools/lib/bpf/bpf_tracing.h
> @@ -215,7 +215,7 @@ struct pt_regs;
> #define PT_REGS_PARM5(x) ((x)->regs[8])
> #define PT_REGS_RET(x) ((x)->regs[31])
> #define PT_REGS_FP(x) ((x)->regs[30]) /* Works only with
> CONFIG_FRAME_POINTER */
> -#define PT_REGS_RC(x) ((x)->regs[1])
> +#define PT_REGS_RC(x) ((x)->regs[2])
> #define PT_REGS_SP(x) ((x)->regs[29])
> #define PT_REGS_IP(x) ((x)->cp0_epc)
>
> --
> 2.17.1
next prev parent reply other threads:[~2020-07-30 23:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 11:44 [PATCH bpf] libbpf: Fix register in PT_REGS MIPS macros Jerry Cruntime
2020-07-30 19:55 ` Andrii Nakryiko
2020-07-30 20:38 ` Jerry Cruntime
2020-07-30 20:43 ` Andrii Nakryiko
2020-07-30 23:00 ` Daniel Borkmann [this message]
2020-07-31 9:56 ` Jerry Crunchtime
2020-07-31 10:31 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76288d74-3110-952a-f068-e040d63dbd7d@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=bpf@vger.kernel.org \
--cc=jerry.c.t@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).