From: Daniel Borkmann <daniel@iogearbox.net>
To: Yafang Shao <laoar.shao@gmail.com>
Cc: ast@kernel.org, andrii@kernel.org, martin.lau@linux.dev,
razor@blackwall.org, sdf@google.com, john.fastabend@gmail.com,
kuba@kernel.org, dxu@dxuuu.xyz, joe@cilium.io, toke@kernel.org,
davem@davemloft.net, bpf@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH bpf-next v6 2/8] bpf: Add fd-based tcx multi-prog infra with link support
Date: Fri, 21 Jul 2023 14:53:05 +0200 [thread overview]
Message-ID: <9f218f1d-3610-9112-2844-334399944164@iogearbox.net> (raw)
In-Reply-To: <CALOAHbAWXNRW4oz+AfUE7h5KJ_6DkRyYn5RWWSvjC5=oNm87QQ@mail.gmail.com>
On 7/20/23 4:13 AM, Yafang Shao wrote:
> On Wed, Jul 19, 2023 at 10:11 PM Daniel Borkmann <daniel@iogearbox.net> wrote:
[...]
>> +static const struct bpf_link_ops tcx_link_lops = {
>> + .release = tcx_link_release,
>> + .detach = tcx_link_detach,
>> + .dealloc = tcx_link_dealloc,
>> + .update_prog = tcx_link_update,
>> + .show_fdinfo = tcx_link_fdinfo,
>> + .fill_link_info = tcx_link_fill_info,
>
> Should we show the tc link info in `bpftool link show` as well? I
> believe that `bpftool link show` is the appropriate command to display
> comprehensive information about all links.
Yep, good idea. I'll add this to my todo list to tackle for once I'm back
from travel.
Thanks,
Daniel
next prev parent reply other threads:[~2023-07-21 12:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 14:08 [PATCH bpf-next v6 0/8] BPF link support for tc BPF programs Daniel Borkmann
2023-07-19 14:08 ` [PATCH bpf-next v6 1/8] bpf: Add generic attach/detach/query API for multi-progs Daniel Borkmann
2023-07-19 14:08 ` [PATCH bpf-next v6 2/8] bpf: Add fd-based tcx multi-prog infra with link support Daniel Borkmann
2023-07-20 2:13 ` Yafang Shao
2023-07-21 12:53 ` Daniel Borkmann [this message]
2023-07-21 14:57 ` Petr Machata
2023-07-21 23:43 ` Daniel Borkmann
2023-07-19 14:08 ` [PATCH bpf-next v6 3/8] libbpf: Add opts-based attach/detach/query API for tcx Daniel Borkmann
2023-07-19 14:08 ` [PATCH bpf-next v6 4/8] libbpf: Add link-based " Daniel Borkmann
2023-07-19 14:08 ` [PATCH bpf-next v6 5/8] libbpf: Add helper macro to clear opts structs Daniel Borkmann
2023-07-19 14:08 ` [PATCH bpf-next v6 6/8] bpftool: Extend net dump with tcx progs Daniel Borkmann
2023-07-19 14:08 ` [PATCH bpf-next v6 7/8] selftests/bpf: Add mprog API tests for BPF tcx opts Daniel Borkmann
2023-07-19 14:08 ` [PATCH bpf-next v6 8/8] selftests/bpf: Add mprog API tests for BPF tcx links Daniel Borkmann
2023-07-19 17:20 ` [PATCH bpf-next v6 0/8] BPF link support for tc BPF programs patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f218f1d-3610-9112-2844-334399944164@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=dxu@dxuuu.xyz \
--cc=joe@cilium.io \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=laoar.shao@gmail.com \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=razor@blackwall.org \
--cc=sdf@google.com \
--cc=toke@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).