From: Aditi Ghag <aditi.ghag@isovalent.com>
To: Martin KaFai Lau <martin.lau@linux.dev>
Cc: bpf@vger.kernel.org, kafai@fb.com, edumazet@google.com,
Stanislav Fomichev <sdf@google.com>
Subject: Re: [PATCH v5 bpf-next 7/7] selftests/bpf: Test bpf_sock_destroy
Date: Mon, 3 Apr 2023 08:55:39 -0700 [thread overview]
Message-ID: <B7A26EB4-55F4-4FAB-B7A2-D7EC37E1E0DC@isovalent.com> (raw)
In-Reply-To: <869f0a0f-0f43-73fb-a361-76009a21b81d@linux.dev>
> On Mar 31, 2023, at 3:32 PM, Martin KaFai Lau <martin.lau@linux.dev> wrote:
>
> On 3/30/23 11:46 AM, Stanislav Fomichev wrote:
>>> +void test_sock_destroy(void)
>>> +{
>>> + struct sock_destroy_prog *skel;
>>> + int cgroup_fd = 0;
>>> +
>>> + skel = sock_destroy_prog__open_and_load();
>>> + if (!ASSERT_OK_PTR(skel, "skel_open"))
>>> + return;
>>> +
>>> + cgroup_fd = test__join_cgroup("/sock_destroy");
>
> Please run this test in its own netns also to avoid affecting other tests as much as possible.
Is it okay if I defer this nit to a follow-up patch? It's not conflicting with other tests at the moment.
>
>>> + if (!ASSERT_GE(cgroup_fd, 0, "join_cgroup"))
>>> + goto close_cgroup_fd;
>>> +
>>> + skel->links.sock_connect = bpf_program__attach_cgroup(
>>> + skel->progs.sock_connect, cgroup_fd);
>>> + if (!ASSERT_OK_PTR(skel->links.sock_connect, "prog_attach"))
>>> + goto close_cgroup_fd;
>>> +
>>> + if (test__start_subtest("tcp_client"))
>>> + test_tcp_client(skel);
>>> + if (test__start_subtest("tcp_server"))
>>> + test_tcp_server(skel);
>>> + if (test__start_subtest("udp_client"))
>>> + test_udp_client(skel);
>>> + if (test__start_subtest("udp_server"))
>>> + test_udp_server(skel);
>>> +
>>> +
>>> +close_cgroup_fd:
>>> + close(cgroup_fd);
>>> + sock_destroy_prog__destroy(skel);
>>> +}
>
next prev parent reply other threads:[~2023-04-03 15:56 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 15:17 [PATCH v5 bpf-next 0/7] bpf: Add socket destroy capability Aditi Ghag
2023-03-30 15:17 ` [PATCH v5 bpf-next 1/7] bpf: tcp: Avoid taking fast sock lock in iterator Aditi Ghag
2023-03-30 15:17 ` [PATCH v5 bpf-next 2/7] udp: seq_file: Remove bpf_seq_afinfo from udp_iter_state Aditi Ghag
2023-03-30 17:35 ` Martin KaFai Lau
2023-03-30 15:17 ` [PATCH v5 bpf-next 3/7] udp: seq_file: Helper function to match socket attributes Aditi Ghag
2023-03-30 18:40 ` kernel test robot
2023-03-30 18:51 ` kernel test robot
2023-03-31 2:52 ` kernel test robot
2023-03-31 20:09 ` Martin KaFai Lau
2023-04-03 15:27 ` Aditi Ghag
2023-04-02 6:18 ` kernel test robot
2023-03-30 15:17 ` [PATCH v5 bpf-next 4/7] bpf: udp: Implement batching for sockets iterator Aditi Ghag
2023-03-31 21:08 ` Martin KaFai Lau
2023-04-03 15:54 ` Aditi Ghag
2023-04-03 19:20 ` Martin KaFai Lau
2023-03-30 15:17 ` [PATCH v5 bpf-next 5/7] bpf: Add bpf_sock_destroy kfunc Aditi Ghag
2023-03-31 22:24 ` Martin KaFai Lau
2023-04-04 6:09 ` [RFC PATCH bpf-next] bpf: Add a kfunc filter function to 'struct btf_kfunc_id_set' Martin KaFai Lau
2023-04-05 15:05 ` Aditi Ghag
2023-04-05 17:26 ` Martin KaFai Lau
2023-04-10 23:05 ` Aditi Ghag
2023-04-12 15:21 ` Aditi Ghag
2023-03-30 15:17 ` [PATCH v5 bpf-next 6/7] selftests/bpf: Add helper to get port using getsockname Aditi Ghag
2023-03-30 18:41 ` Stanislav Fomichev
2023-03-31 21:37 ` Martin KaFai Lau
2023-03-30 15:17 ` [PATCH v5 bpf-next 7/7] selftests/bpf: Test bpf_sock_destroy Aditi Ghag
2023-03-30 18:46 ` Stanislav Fomichev
2023-03-31 22:32 ` Martin KaFai Lau
2023-04-03 15:55 ` Aditi Ghag [this message]
2023-04-03 17:35 ` Martin KaFai Lau
2023-04-04 0:15 ` Aditi Ghag
2023-04-04 1:41 ` Martin KaFai Lau
2023-04-04 14:24 ` Aditi Ghag
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B7A26EB4-55F4-4FAB-B7A2-D7EC37E1E0DC@isovalent.com \
--to=aditi.ghag@isovalent.com \
--cc=bpf@vger.kernel.org \
--cc=edumazet@google.com \
--cc=kafai@fb.com \
--cc=martin.lau@linux.dev \
--cc=sdf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).