bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rumen Telbizov <rumen.telbizov@menlosecurity.com>
To: bpf@vger.kernel.org
Cc: Daniel Borkmann <daniel@iogearbox.net>,
	David Ahern <dsahern@gmail.com>,
	Jesper Dangaard Brouer <brouer@redhat.com>
Subject: Re: bpf_fib_lookup support for firewall mark
Date: Tue, 29 Jun 2021 10:18:14 -0700	[thread overview]
Message-ID: <CA+FoirBfFwHg78_G+LdxR=x0bRVViG2QXPn9Rsb_7DfZQY4t8w@mail.gmail.com> (raw)
In-Reply-To: <CA+FoirA-eAfux3PfxjgyO=--7duWCKuyeJfxWTdW6jiMWzShTw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 937 bytes --]

Daniel, BPF list,

Over the last week or so David Ahern and I worked on a patchset that solves
the problem discussed here along with a self-test.

Attached here is a patchset of 3 files which covers the following:

[PATCH 1/3] bpf: Add support for mark with bpf_fib_lookup
[PATCH 2/3] tools: Update bpf header
[PATCH 3/3] selftests: Add selftests for fwmark support in bpf_fib_lookup

I have tested those against a very recent clone of the latest 5.13-rc7.
Self-test results look like this:

----
# ./test_bpf_fib_lookup.sh
[test_bpf_fib_lookup.sh] START
- Running test_egress_ipv4_fwmark
  * mark 0: PASS
  * mark 2: PASS
- Running test_egress_ipv6_fwmark
  * mark 0: PASS
  * mark 2: PASS
[test_bpf_fib_lookup.sh] PASS: 4 -- FAIL: 0
# echo $?
0
----

Let me know what you think and if there's anything else needed to incorporate
the patchset into the kernel as well as what you think the next steps should be.

Regards,
Rumen Telbizov

[-- Attachment #2: 0002-tools-Update-bpf-header.patch --]
[-- Type: application/x-patch, Size: 1121 bytes --]

[-- Attachment #3: 0003-selftests-Add-selftests-for-fwmark-support-in-bpf_fi.patch --]
[-- Type: application/x-patch, Size: 10687 bytes --]

[-- Attachment #4: 0001-bpf-Add-support-for-mark-with-bpf_fib_lookup.patch --]
[-- Type: application/x-patch, Size: 2832 bytes --]

  parent reply	other threads:[~2021-06-29 17:18 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-08 22:59 bpf_fib_lookup support for firewall mark Rumen Telbizov
2021-06-09  1:21 ` David Ahern
2021-06-09 18:30   ` Rumen Telbizov
2021-06-09 21:56     ` Rumen Telbizov
2021-06-09 22:08       ` Daniel Borkmann
2021-06-10 14:37         ` David Ahern
2021-06-10 17:41           ` Rumen Telbizov
2021-06-10 18:52             ` David Ahern
2021-06-10 20:58               ` Daniel Borkmann
2021-06-11  1:41                 ` David Ahern
2021-06-11 17:32                   ` Rumen Telbizov
     [not found]                     ` <CA+FoirA-eAfux3PfxjgyO=--7duWCKuyeJfxWTdW6jiMWzShTw@mail.gmail.com>
2021-06-12  0:00                       ` Rumen Telbizov
2021-06-12  1:13                       ` David Ahern
2021-06-14 16:53                         ` Rumen Telbizov
2021-06-29 17:18                       ` Rumen Telbizov [this message]
2021-06-29 17:21                         ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+FoirBfFwHg78_G+LdxR=x0bRVViG2QXPn9Rsb_7DfZQY4t8w@mail.gmail.com' \
    --to=rumen.telbizov@menlosecurity.com \
    --cc=bpf@vger.kernel.org \
    --cc=brouer@redhat.com \
    --cc=daniel@iogearbox.net \
    --cc=dsahern@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).