Re: [PATCHv2] btf_encoder: Match ftrace addresses within elf functions

From: Sedat Dilek <sedat.dilek@gmail.com>
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>, Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Andrii Nakryiko <andriin@fb.com>,
	Andrii Nakryiko <andrii@kernel.org>,
	dwarves@vger.kernel.org, netdev@vger.kernel.org,
	bpf@vger.kernel.org, Yonghong Song <yhs@fb.com>,
	Hao Luo <haoluo@google.com>, Martin KaFai Lau <kafai@fb.com>,
	Song Liu <songliubraving@fb.com>,
	John Fastabend <john.fastabend@gmail.com>,
	KP Singh <kpsingh@chromium.org>,
	Nathan Chancellor <nathan@kernel.org>
Subject: Re: [PATCHv2] btf_encoder: Match ftrace addresses within elf functions
Date: Wed, 17 Feb 2021 19:02:26 +0100	[thread overview]
Message-ID: <CA+icZUWC-OuV1dJv6PsmbjU7fMSY02RFa8X1LLmJB3xh=W0O_A@mail.gmail.com> (raw)
In-Reply-To: <AA8690FE-7C57-4791-881A-DE06B337DF45@gmail.com>

On Wed, Feb 17, 2021 at 2:56 PM Arnaldo Carvalho de Melo
<arnaldo.melo@gmail.com> wrote:
>
>
>
> On February 17, 2021 10:40:43 AM GMT-03:00, Sedat Dilek <sedat.dilek@gmail.com> wrote:
> >On Wed, Feb 17, 2021 at 1:44 PM Arnaldo Carvalho de Melo
> ><arnaldo.melo@gmail.com> wrote:
> >>
> >> Em Sat, Feb 13, 2021 at 05:46:48PM +0100, Jiri Olsa escreveu:
> >> > Currently when processing DWARF function, we check its entrypoint
> >> > against ftrace addresses, assuming that the ftrace address matches
> >> > with function's entrypoint.
> >> >
> >> > This is not the case on some architectures as reported by Nathan
> >> > when building kernel on arm [1].
> >> >
> >> > Fixing the check to take into account the whole function not
> >> > just the entrypoint.
> >> >
> >> > Most of the is_ftrace_func code was contributed by Andrii.
> >>
> >> Applied locally, will go out after tests,
> >>
> >
> >Hi Arnaldo,
> >
> >Is it possible to have a pahole version 1.21 with this patch and the
> >one from Yonghong Son?
> >
> >From my local pahole Git:
> >
> >$ git log --oneline --no-merges v1.20..
> >2f83aefdbddf (for-1.20/btf_encoder-ftrace_elf-clang-jolsa-v2)
> >btf_encoder: Match ftrace addresses within elf functions
> >f21eafdfc877 (for-1.20/btf_encoder-sanitized_int-clang-yhs-v2)
> >btf_encoder: sanitize non-regular int base type
> >
> >Both patches fixes all issues seen so far with LLVM/Clang >=
> >12.0.0-rc1 and DWARF-v5 and BTF (debug-info) and pahole on
> >Linux/x86_64 and according to Nathan on Linux/arm64.
> >Yesterday, I tried with LLVM/Clang 13-git from <apt.llvm.org>.
> >
> >BTW, Nick's DWARF-v5 patches are pending in <kbuild.git#kbuild> (see
> >[1]).
> >
> >Personally, I can wait until [1] is in Linus Git.
> >
> >Please, let me/us know what you are planning.
> >( I know it is Linux v5.12 merge-window. )
>
> Sure, next week.
>

That's OK with me.

- Sedat -

> - Arnaldo
>
> >
> >Regards,
> >- Sedat -
> >
> >[1]
> >https://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git/log/?h=kbuild
>
> --
> Sent from my Android device with K-9 Mail. Please excuse my brevity.