From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: John Fastabend <john.fastabend@gmail.com>
Cc: "Toke Høiland-Jørgensen" <toke@redhat.com>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Alexei Starovoitov" <ast@fb.com>, bpf <bpf@vger.kernel.org>,
"Network Development" <netdev@vger.kernel.org>,
"Tetsuo Handa" <penguin-kernel@i-love.sakura.ne.jp>
Subject: Re: [PATCH] xdp: Fix cleanup on map free for devmap_hash map type
Date: Thu, 21 Nov 2019 23:18:36 -0800 [thread overview]
Message-ID: <CAADnVQJ6rd7Y7ZgoKLwpQNs6dni=jhbE+2OtedwHcZ71yyry7g@mail.gmail.com> (raw)
In-Reply-To: <5dd701c21871b_4e932af130aba5bc48@john-XPS-13-9370.notmuch>
On Thu, Nov 21, 2019 at 1:32 PM John Fastabend <john.fastabend@gmail.com> wrote:
>
> Toke Høiland-Jørgensen wrote:
> > Tetsuo pointed out that it was not only the device unregister hook that was
> > broken for devmap_hash types, it was also cleanup on map free. So better
> > fix this as well.
> >
> > While we're add it, there's no reason to allocate the netdev_map array for
> ^^^
> at
> > DEVMAP_HASH, so skip that and adjust the cost accordingly.
>
> Beyond saving space without pulling these apart the free would have gotten
> fairly ugly.
>
> >
> > Fixes: 6f9d451ab1a3 ("xdp: Add devmap_hash map type for looking up devices by hashed index")
> > Reported-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> > Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
> > ---
> > kernel/bpf/devmap.c | 74 ++++++++++++++++++++++++++++-----------------
> > 1 file changed, 46 insertions(+), 28 deletions(-)
>
> small typo in commit message otherwise
>
> Acked-by: John Fastabend <john.fastabend@gmail.com>
Fixed the typo and applied to bpf-next. Thanks
prev parent reply other threads:[~2019-11-22 7:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 13:36 [PATCH] xdp: Fix cleanup on map free for devmap_hash map type Toke Høiland-Jørgensen
2019-11-21 21:29 ` John Fastabend
2019-11-22 7:18 ` Alexei Starovoitov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAADnVQJ6rd7Y7ZgoKLwpQNs6dni=jhbE+2OtedwHcZ71yyry7g@mail.gmail.com' \
--to=alexei.starovoitov@gmail.com \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).