From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Yonghong Song <yhs@fb.com>
Cc: bpf <bpf@vger.kernel.org>, Alexei Starovoitov <ast@fb.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Kernel Team <kernel-team@fb.com>
Subject: Re: [PATCH bpf-next v2 0/2] bpf: provide better register bounds after jmp32 instructions
Date: Fri, 22 Nov 2019 10:37:37 -0800 [thread overview]
Message-ID: <CAADnVQJWAvjMsGA2GrdZv1ZCh1z_yeHky-hpy7K5E4XAeyEntQ@mail.gmail.com> (raw)
In-Reply-To: <20191121170650.448973-1-yhs@fb.com>
On Thu, Nov 21, 2019 at 9:08 AM Yonghong Song <yhs@fb.com> wrote:
>
> With latest llvm, bpf selftest test_progs, which has +alu32 enabled, failed for
> strobemeta.o and a few other subtests. The reason is due to that
> verifier did not provide better var_off.mask after jmp32 instructions.
> This patch set addressed this issue and after the fix, test_progs passed
> with alu32.
>
> Patch #1 provided detailed explanation of the problem and the fix.
> Patch #2 added three tests in test_verifier.
>
> Changelog:
> v1 -> v2:
> - do not directly manipulate tnum.{value,mask} in __reg_bound_offset32(),
> using tnum_lshift/tnum_rshift functions instead
> - do __reg_bound_offset32() after regular 64bit __reg_bound_offset()
> since the latter may give a better upper 32bit var_off, which can
> be inherited by __reg_bound_offset32().
I fixed white space damage and adjusted subject line of patch 2.
And applied to bpf-next. Thanks
prev parent reply other threads:[~2019-11-22 18:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 17:06 [PATCH bpf-next v2 0/2] bpf: provide better register bounds after jmp32 instructions Yonghong Song
2019-11-21 17:06 ` [PATCH bpf-next v2 1/2] " Yonghong Song
2019-11-21 17:06 ` [PATCH bpf-next v2 2/2] tools/bpf: add verifier tests for better jmp32 register bounds Yonghong Song
2019-11-22 18:37 ` Alexei Starovoitov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAADnVQJWAvjMsGA2GrdZv1ZCh1z_yeHky-hpy7K5E4XAeyEntQ@mail.gmail.com \
--to=alexei.starovoitov@gmail.com \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).