bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Andrii Nakryiko <andrii@kernel.org>
Cc: bpf <bpf@vger.kernel.org>,
	Network Development <netdev@vger.kernel.org>,
	Alexei Starovoitov <ast@fb.com>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Kernel Team <kernel-team@fb.com>,
	Lorenz Bauer <lmb@cloudflare.com>
Subject: Re: [PATCH v2 bpf-next 0/5] CO-RE relocation selftests fixes
Date: Mon, 26 Apr 2021 18:43:09 -0700	[thread overview]
Message-ID: <CAADnVQKQ5ZddWKtEbWf16xbN-QXuLP8DZJbHg48y=RyHJ2v8EA@mail.gmail.com> (raw)
In-Reply-To: <20210426192949.416837-1-andrii@kernel.org>

On Mon, Apr 26, 2021 at 12:30 PM Andrii Nakryiko <andrii@kernel.org> wrote:
>
> Lorenz Bauer noticed that core_reloc selftest has two inverted CHECK()
> conditions, allowing failing tests to pass unnoticed. Fixing that opened up
> few long-standing (field existence and direct memory bitfields) and one recent
> failures (BTF_KIND_FLOAT relos).
>
> This patch set fixes core_reloc selftest to capture such failures reliably in
> the future. It also fixes all the newly failing tests. See individual patches
> for details.
>
> This patch set also completes a set of ASSERT_xxx() macros, so now there
> should be a very little reason to use verbose and error-prone generic CHECK()
> macro.
>
> v1->v2:
>   - updated bpf_core_fields_are_compat() comment to mention FLOAT (Lorenz).

Applied.

      parent reply	other threads:[~2021-04-27  1:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-26 19:29 [PATCH v2 bpf-next 0/5] CO-RE relocation selftests fixes Andrii Nakryiko
2021-04-26 19:29 ` [PATCH v2 bpf-next 1/5] selftests/bpf: add remaining ASSERT_xxx() variants Andrii Nakryiko
2021-04-26 19:29 ` [PATCH v2 bpf-next 2/5] libbpf: support BTF_KIND_FLOAT during type compatibility checks in CO-RE Andrii Nakryiko
2021-04-26 19:29 ` [PATCH v2 bpf-next 3/5] selftests/bpf: fix BPF_CORE_READ_BITFIELD() macro Andrii Nakryiko
2021-04-26 19:29 ` [PATCH v2 bpf-next 4/5] selftests/bpf: fix field existence CO-RE reloc tests Andrii Nakryiko
2021-04-26 19:29 ` [PATCH v2 bpf-next 5/5] selftests/bpf: fix core_reloc test runner Andrii Nakryiko
2021-04-27  1:43 ` Alexei Starovoitov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAADnVQKQ5ZddWKtEbWf16xbN-QXuLP8DZJbHg48y=RyHJ2v8EA@mail.gmail.com' \
    --to=alexei.starovoitov@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@fb.com \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=kernel-team@fb.com \
    --cc=lmb@cloudflare.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).