From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10741C4332D for ; Thu, 14 Jan 2021 02:06:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DE20023442 for ; Thu, 14 Jan 2021 02:06:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729841AbhANCFz (ORCPT ); Wed, 13 Jan 2021 21:05:55 -0500 Received: from mail.kernel.org ([198.145.29.99]:45404 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729302AbhAMW3q (ORCPT ); Wed, 13 Jan 2021 17:29:46 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 39EF823434 for ; Wed, 13 Jan 2021 22:29:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610576945; bh=srLRPLK5YXTuhUWWEHIPjYvPj65Ukrwxe3nwgOVQ1H4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=BDH1F9rcJtI4Q0+49LL11CWjXcM8SruYfVwIiIGJerbKhGRLAxcKLSAt+qK2b9KFF NwxaKjgnukIfeo109QKruQRNc66yXVrNVI1iY6hiWeIMR3u67hPoV7GA6VwA/jbk0J 7Y0ypCT/Z8AeZT1DJvGC7jd60dKJb9CtD/9GuYhTRypi/ZkLv3wW7QEe0XXvAQwSzj GnNkrxSGKKlriE3ld8VSioPb8/BnIyB2ZNRXYYdxhYoZ3PCFcs/0szGB4aYVK7LstN fpftl9LRQ3A+HKOKdQywPy+0zOSWRtlBJZxEtTeMVTa/5G/OGeiFpAL3FfK6XBiku5 6OrGLIfG73Q9g== Received: by mail-lj1-f175.google.com with SMTP id p13so4383883ljg.2 for ; Wed, 13 Jan 2021 14:29:05 -0800 (PST) X-Gm-Message-State: AOAM531j758ebHcWP5H9/sm+UAi7tULro5pdnN9b85R9ybdLhQXKrxUc NT6BnMBZXNLKst15wNruviwS6UY+zFa7QsXWxnSKew== X-Google-Smtp-Source: ABdhPJy1Ii5PE8b9neNCZi8w33t2B6xijbS6dW3x4eYy87VeFjivFp9gmChTGHBx06NwCCVvvuQ6Zbm2DUJmVRc5QZM= X-Received: by 2002:a2e:9b1a:: with SMTP id u26mr1828558lji.187.1610576943394; Wed, 13 Jan 2021 14:29:03 -0800 (PST) MIME-Version: 1.0 References: <20210113053810.13518-1-gilad.reti@gmail.com> <20210113053810.13518-2-gilad.reti@gmail.com> In-Reply-To: From: KP Singh Date: Wed, 13 Jan 2021 23:28:53 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH bpf v2 2/2] selftests/bpf: add verifier test for PTR_TO_MEM spill To: Yonghong Song Cc: Gilad Reti , bpf , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , John Fastabend , Shuah Khan , Networking , open list , linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Wed, Jan 13, 2021 at 5:05 PM Yonghong Song wrote: > > > > On 1/12/21 9:38 PM, Gilad Reti wrote: > > Add a test to check that the verifier is able to recognize spilling of > > PTR_TO_MEM registers, by reserving a ringbuf buffer, forcing the spill > > of a pointer holding the buffer address to the stack, filling it back > > in from the stack and writing to the memory area pointed by it. > > > > The patch was partially contributed by CyberArk Software, Inc. > > > > Signed-off-by: Gilad Reti > > I didn't verify result_unpriv = ACCEPT part. I think it is correct > by checking code. > > Acked-by: Yonghong Song Thanks for the description! Acked-by: KP Singh