From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Wei Li <liwei391@huawei.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>, bpf <bpf@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
huawei.libin@huawei.com
Subject: Re: [PATCH] tools: bpf: Fix error in 'make -C tools/ bpf_install'
Date: Wed, 7 Jul 2021 14:09:11 -0700 [thread overview]
Message-ID: <CAEf4BzYYc2GyvWxKhAe9XY3zTCo2VQRHCo7jN9xU9wKOfoJDLA@mail.gmail.com> (raw)
In-Reply-To: <20210628030409.3459095-1-liwei391@huawei.com>
On Sun, Jun 27, 2021 at 8:05 PM Wei Li <liwei391@huawei.com> wrote:
>
> make[2]: *** No rule to make target 'install'. Stop.
> make[1]: *** [Makefile:122: runqslower_install] Error 2
> make: *** [Makefile:116: bpf_install] Error 2
>
> There is no rule for target 'install' in tools/bpf/runqslower/Makefile,
> and there is no need to install it, so just remove 'runqslower_install'.
>
> Fixes: 9c01546d26d2 ("tools/bpf: Add runqslower tool to tools/bpf")
> Signed-off-by: Wei Li <liwei391@huawei.com>
> ---
Applied to bpf tree, thanks.
Technically runqslower could be installed, but it's better to leave
that to libbpf-tools ([0]), which distributes runqslower along other
BPF-based tools.
[0] https://github.com/iovisor/bcc/tree/master/libbpf-tools
> tools/bpf/Makefile | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/tools/bpf/Makefile b/tools/bpf/Makefile
> index 39bb322707b4..b11cfc86a3d0 100644
> --- a/tools/bpf/Makefile
> +++ b/tools/bpf/Makefile
> @@ -97,7 +97,7 @@ clean: bpftool_clean runqslower_clean resolve_btfids_clean
> $(Q)$(RM) -- $(OUTPUT)FEATURE-DUMP.bpf
> $(Q)$(RM) -r -- $(OUTPUT)feature
>
> -install: $(PROGS) bpftool_install runqslower_install
> +install: $(PROGS) bpftool_install
> $(call QUIET_INSTALL, bpf_jit_disasm)
> $(Q)$(INSTALL) -m 0755 -d $(DESTDIR)$(prefix)/bin
> $(Q)$(INSTALL) $(OUTPUT)bpf_jit_disasm $(DESTDIR)$(prefix)/bin/bpf_jit_disasm
> @@ -118,9 +118,6 @@ bpftool_clean:
> runqslower:
> $(call descend,runqslower)
>
> -runqslower_install:
> - $(call descend,runqslower,install)
> -
> runqslower_clean:
> $(call descend,runqslower,clean)
>
> @@ -131,5 +128,5 @@ resolve_btfids_clean:
> $(call descend,resolve_btfids,clean)
>
> .PHONY: all install clean bpftool bpftool_install bpftool_clean \
> - runqslower runqslower_install runqslower_clean \
> + runqslower runqslower_clean \
> resolve_btfids resolve_btfids_clean
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-07-07 21:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 3:04 [PATCH] tools: bpf: Fix error in 'make -C tools/ bpf_install' Wei Li
2021-07-07 21:09 ` Andrii Nakryiko [this message]
2021-07-07 21:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEf4BzYYc2GyvWxKhAe9XY3zTCo2VQRHCo7jN9xU9wKOfoJDLA@mail.gmail.com \
--to=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=huawei.libin@huawei.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liwei391@huawei.com \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).