From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9245DC742A1 for ; Fri, 12 Jul 2019 00:22:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 65B292084B for ; Fri, 12 Jul 2019 00:22:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="tN59z30f" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730201AbfGLAWJ (ORCPT ); Thu, 11 Jul 2019 20:22:09 -0400 Received: from mail-qt1-f196.google.com ([209.85.160.196]:35061 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728102AbfGLAWI (ORCPT ); Thu, 11 Jul 2019 20:22:08 -0400 Received: by mail-qt1-f196.google.com with SMTP id d23so6407979qto.2; Thu, 11 Jul 2019 17:22:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/4+k8OBkWPl2wP9Mpj886E0SFBIDse14POqVOVVgzkg=; b=tN59z30f+lg/v89y4PZ/8rnECfXHofqbiSuoJxqTCXj4tF1s4jMkyscCyYzegIEa4/ r1+0RZnxuXiif2blTLuplY2vy/82FJbOS80Foee/TlcOaPffxDRVUuOsmHxZpc1fblGd DuyeN/aXH8NAjJSF1vVNjKxyZHvj9LHrhuOrVTChmvTcrOFZ80uT5p5x8SB7tk/V5ePN Vp/RpFYIS4me8u4WUNWijXORxDKZLEkDorasmEg+KoFbAcNEtNT4P8327oYUitpOsqps 7yy7VBTIyfI8GLNNaD5qXdwtn5jE1NV3XlgL6fWrw1T0Pe5DrGZ6HtcOZTIhA/W8ZdyD u/Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/4+k8OBkWPl2wP9Mpj886E0SFBIDse14POqVOVVgzkg=; b=Xc8/PZHG++N8NqZGjhOcu903Ce3YpbEkQ3u6ZXU1tSG5W3/go2ZEZTGEOtz9f3M3ib 9p5B0KGoA06vJPEqtkHjFK1mdyzv6/YsPMcgicB/Y5lF4v5U++b4c7boIpVW7ZwrRqLc 1SllfAiL38uhRvaPk4seYSbG5EAn6P6TnoT+i/yr2xqAqg9SQ10DCYrjSRurU90Fp0VO amhghvnziWII2VrSfUnZSl12/g3aw1A1tAeWxhkPrxXOh5fF/N/eKArOQJ7DfClS5Rd9 QnwWMnMdjJTRSCcsN3qgcMtCdgRKCUuRs47ArLqtKHD7Rk+AKtWIERhi9T8PP2dj77jo 5KEw== X-Gm-Message-State: APjAAAUMx63EHnFIaR45hFTMFBKrRU9njf5jaNMZf2dIpn9fMJ8MsX8b wbGndyupqePFNva704yhV+eQZ9Uhabapl7vEvxI= X-Google-Smtp-Source: APXvYqxRcNPW7o70Lv/0ta0iz/AgsAPC23tElXsi8v0Rjw3QFg66LYJNUS+dkJrYikGIOp6Tbd9q6mZyOtzcmRnLt9k= X-Received: by 2002:a05:6214:1306:: with SMTP id a6mr4329977qvv.38.1562890927633; Thu, 11 Jul 2019 17:22:07 -0700 (PDT) MIME-Version: 1.0 References: <20190708163121.18477-1-krzesimir@kinvolk.io> <20190708163121.18477-9-krzesimir@kinvolk.io> In-Reply-To: <20190708163121.18477-9-krzesimir@kinvolk.io> From: Andrii Nakryiko Date: Thu, 11 Jul 2019 17:21:56 -0700 Message-ID: Subject: Re: [bpf-next v3 08/12] tools headers: Sync struct bpf_perf_event_data To: Krzesimir Nowak Cc: open list , Alban Crequy , =?UTF-8?Q?Iago_L=C3=B3pez_Galeiras?= , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , Networking , bpf , xdp-newbies@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Mon, Jul 8, 2019 at 3:42 PM Krzesimir Nowak wrote: > > struct bpf_perf_event_data in kernel headers has the addr field, which > is missing in the tools version of the struct. This will be important > for the bpf prog test run implementation for perf events as it will > expect data to be an instance of struct bpf_perf_event_data, so the > size of the data needs to match sizeof(bpf_perf_event_data). > > Signed-off-by: Krzesimir Nowak > --- Acked-by: Andrii Nakryiko > tools/include/uapi/linux/bpf_perf_event.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/include/uapi/linux/bpf_perf_event.h b/tools/include/uapi/linux/bpf_perf_event.h > index 8f95303f9d80..eb1b9d21250c 100644 > --- a/tools/include/uapi/linux/bpf_perf_event.h > +++ b/tools/include/uapi/linux/bpf_perf_event.h > @@ -13,6 +13,7 @@ > struct bpf_perf_event_data { > bpf_user_pt_regs_t regs; > __u64 sample_period; > + __u64 addr; > }; > > #endif /* _UAPI__LINUX_BPF_PERF_EVENT_H__ */ > -- > 2.20.1 >