From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Eric Sage <eric@sage.org>
Cc: bpf <bpf@vger.kernel.org>, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>, Martin Lau <kafai@fb.com>,
Yonghong Song <yhs@fb.com>, Andrii Nakryiko <andriin@fb.com>,
Jakub Kicinski <jakub.kicinski@netronome.com>,
Jesper Dangaard Brouer <hawk@kernel.org>,
john fastabend <john.fastabend@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Networking <netdev@vger.kernel.org>
Subject: Re: [PATCH v3] samples/bpf: Add xdp_stat sample program
Date: Thu, 30 Jan 2020 10:52:00 -0800 [thread overview]
Message-ID: <CAEf4BzZOWRyuhDUdbCt0fqroaX1sGaTpwPohKwntFm+KivkWnQ@mail.gmail.com> (raw)
In-Reply-To: <20200129035457.90892-1-eric@sage.org>
On Tue, Jan 28, 2020 at 7:55 PM Eric Sage <eric@sage.org> wrote:
>
> At Facebook we use tail calls to jump between our firewall filters and
> our L4LB. This is a program I wrote to estimate per program performance
> by swapping out the entries in the program array with interceptors that
> take measurements and then jump to the original entries.
>
> I found the sample programs to be invaluable in understanding how to use
> the libbpf API (as well as the test env from the xdp-tutorial repo for
> testing), and want to return the favor. I am currently working on
> my next iteration that uses fentry/fexit to be less invasive,
> but I thought it was an interesting PoC of what you can do with program
> arrays.
>
> Signed-off-by: Eric Sage <eric@sage.org>
> ---
Looks good, thanks!
Acked-by: Andrii Nakryiko <andriin@fb.com>
> Changes in v3:
> - Fixed typos in xdp_stat_kern.c
> - Switch to using key_size, value_size for prog arrays.
>
Just for the future: you should keep entire changelog, starting from
v1->v2 changes. Also, netdev patches usually preserve them as part of
commit message (for individual patch) or cover letter (for patch set).
But in this case I think changes are not substantial enough to record
them permanently, so it's fine.
[...]
next prev parent reply other threads:[~2020-01-30 18:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-29 22:51 [PATCH] samples/bpf: Add xdp_stat sample program Eric Sage
2020-01-10 20:53 ` Andrii Nakryiko
2020-01-12 4:02 ` [PATCH v2] " Eric Sage
2020-01-13 20:35 ` Andrii Nakryiko
2020-01-29 3:54 ` [PATCH v3] " Eric Sage
2020-01-30 18:52 ` Andrii Nakryiko [this message]
2020-02-17 15:22 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEf4BzZOWRyuhDUdbCt0fqroaX1sGaTpwPohKwntFm+KivkWnQ@mail.gmail.com \
--to=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eric@sage.org \
--cc=hawk@kernel.org \
--cc=jakub.kicinski@netronome.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=netdev@vger.kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).