bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Hou Tao <houtao1@huawei.com>
Cc: Alexei Starovoitov <ast@kernel.org>, Yonghong Song <yhs@fb.com>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Andrii Nakryiko <andrii@kernel.org>,
	Martin KaFai Lau <kafai@fb.com>,
	Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH bpf-next v4 1/3] bpf: support writable context for bare tracepoint
Date: Fri, 1 Oct 2021 15:21:49 -0700	[thread overview]
Message-ID: <CAEf4BzardNSbbbDkSJR9GTcpOvmJsYuFqT996dLkJiGHFXZkqg@mail.gmail.com> (raw)
In-Reply-To: <20210930091355.2794601-2-houtao1@huawei.com>

On Thu, Sep 30, 2021 at 2:00 AM Hou Tao <houtao1@huawei.com> wrote:
>
> Commit 9df1c28bb752 ("bpf: add writable context for raw tracepoints")
> supports writable context for tracepoint, but it misses the support
> for bare tracepoint which has no associated trace event.
>
> Bare tracepoint is defined by DECLARE_TRACE(), so adding a corresponding
> DECLARE_TRACE_WRITABLE() macro to generate a definition in __bpf_raw_tp_map
> section for bare tracepoint in a similar way to DEFINE_TRACE_WRITABLE().
>
> Signed-off-by: Hou Tao <houtao1@huawei.com>
> ---

LGTM.

Acked-by: Andrii Nakryiko <andrii@kernel.org>

>  include/trace/bpf_probe.h | 19 +++++++++++++++----
>  1 file changed, 15 insertions(+), 4 deletions(-)
>
> diff --git a/include/trace/bpf_probe.h b/include/trace/bpf_probe.h
> index a23be89119aa..a8e97f84b652 100644
> --- a/include/trace/bpf_probe.h
> +++ b/include/trace/bpf_probe.h
> @@ -93,8 +93,7 @@ __section("__bpf_raw_tp_map") = {                                     \
>
>  #define FIRST(x, ...) x
>
> -#undef DEFINE_EVENT_WRITABLE
> -#define DEFINE_EVENT_WRITABLE(template, call, proto, args, size)       \
> +#define __CHECK_WRITABLE_BUF_SIZE(call, proto, args, size)             \
>  static inline void bpf_test_buffer_##call(void)                                \
>  {                                                                      \
>         /* BUILD_BUG_ON() is ignored if the code is completely eliminated, but \
> @@ -103,8 +102,12 @@ static inline void bpf_test_buffer_##call(void)                            \
>          */                                                             \
>         FIRST(proto);                                                   \
>         (void)BUILD_BUG_ON_ZERO(size != sizeof(*FIRST(args)));          \
> -}                                                                      \
> -__DEFINE_EVENT(template, call, PARAMS(proto), PARAMS(args), size)
> +}
> +
> +#undef DEFINE_EVENT_WRITABLE
> +#define DEFINE_EVENT_WRITABLE(template, call, proto, args, size) \
> +       __CHECK_WRITABLE_BUF_SIZE(call, PARAMS(proto), PARAMS(args), size) \
> +       __DEFINE_EVENT(template, call, PARAMS(proto), PARAMS(args), size)
>
>  #undef DEFINE_EVENT
>  #define DEFINE_EVENT(template, call, proto, args)                      \
> @@ -119,9 +122,17 @@ __DEFINE_EVENT(template, call, PARAMS(proto), PARAMS(args), size)
>         __BPF_DECLARE_TRACE(call, PARAMS(proto), PARAMS(args))          \
>         __DEFINE_EVENT(call, call, PARAMS(proto), PARAMS(args), 0)
>
> +#undef DECLARE_TRACE_WRITABLE
> +#define DECLARE_TRACE_WRITABLE(call, proto, args, size) \
> +       __CHECK_WRITABLE_BUF_SIZE(call, PARAMS(proto), PARAMS(args), size) \
> +       __BPF_DECLARE_TRACE(call, PARAMS(proto), PARAMS(args)) \
> +       __DEFINE_EVENT(call, call, PARAMS(proto), PARAMS(args), size)
> +
>  #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
>
> +#undef DECLARE_TRACE_WRITABLE
>  #undef DEFINE_EVENT_WRITABLE
> +#undef __CHECK_WRITABLE_BUF_SIZE
>  #undef __DEFINE_EVENT
>  #undef FIRST
>
> --
> 2.29.2
>

  reply	other threads:[~2021-10-01 22:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-30  9:13 [PATCH bpf-next v4 0/3] add support for writable bare tracepoint Hou Tao
2021-09-30  9:13 ` [PATCH bpf-next v4 1/3] bpf: support writable context for " Hou Tao
2021-10-01 22:21   ` Andrii Nakryiko [this message]
2021-09-30  9:13 ` [PATCH bpf-next v4 2/3] libbpf: support detecting and attaching of writable tracepoint program Hou Tao
2021-10-01 22:21   ` Andrii Nakryiko
2021-09-30  9:13 ` [PATCH bpf-next v4 3/3] bpf/selftests: add test for writable bare tracepoint Hou Tao
2021-09-30  9:13 ` [PATCH bpf-next v4 0/3] add support " Hou Tao
2021-09-30 10:06   ` Hou Tao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEf4BzardNSbbbDkSJR9GTcpOvmJsYuFqT996dLkJiGHFXZkqg@mail.gmail.com \
    --to=andrii.nakryiko@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=houtao1@huawei.com \
    --cc=kafai@fb.com \
    --cc=netdev@vger.kernel.org \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).