From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: Alexei Starovoitov <ast@kernel.org>,
john fastabend <john.fastabend@gmail.com>,
Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH bpf-next v2 8/8] bpf, testing: add various tail call test cases
Date: Fri, 22 Nov 2019 15:14:15 -0800 [thread overview]
Message-ID: <CAEf4BzbLeKYC7WJtqDkZQh6sVm4dw-aFgtUsO2Phb8DDxzaDEw@mail.gmail.com> (raw)
In-Reply-To: <3d6cbecbeb171117dccfe153306e479798fb608d.1574452833.git.daniel@iogearbox.net>
On Fri, Nov 22, 2019 at 12:08 PM Daniel Borkmann <daniel@iogearbox.net> wrote:
>
> Add several BPF kselftest cases for tail calls which test the various
> patch directions, and that multiple locations are patched in same and
> different programs.
>
> # ./test_progs -n 45
> #45/1 tailcall_1:OK
> #45/2 tailcall_2:OK
> #45/3 tailcall_3:OK
> #45/4 tailcall_4:OK
> #45/5 tailcall_5:OK
> #45 tailcalls:OK
> Summary: 1/5 PASSED, 0 SKIPPED, 0 FAILED
>
> I've also verified the JITed dump after each of the rewrite cases that
> it matches expectations.
>
> Also regular test_verifier suite passes fine which contains further tail
> call tests:
>
> # ./test_verifier
> [...]
> Summary: 1563 PASSED, 0 SKIPPED, 0 FAILED
>
> Checked under JIT, interpreter and JIT + hardening.
>
> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
> ---
LGTM. Thanks for adding more tests!
Acked-by: Andrii Nakryiko <andriin@fb.com>
> .../selftests/bpf/prog_tests/tailcalls.c | 487 ++++++++++++++++++
> tools/testing/selftests/bpf/progs/tailcall1.c | 48 ++
> tools/testing/selftests/bpf/progs/tailcall2.c | 59 +++
> tools/testing/selftests/bpf/progs/tailcall3.c | 31 ++
> tools/testing/selftests/bpf/progs/tailcall4.c | 33 ++
> tools/testing/selftests/bpf/progs/tailcall5.c | 40 ++
> 6 files changed, 698 insertions(+)
> create mode 100644 tools/testing/selftests/bpf/prog_tests/tailcalls.c
> create mode 100644 tools/testing/selftests/bpf/progs/tailcall1.c
> create mode 100644 tools/testing/selftests/bpf/progs/tailcall2.c
> create mode 100644 tools/testing/selftests/bpf/progs/tailcall3.c
> create mode 100644 tools/testing/selftests/bpf/progs/tailcall4.c
> create mode 100644 tools/testing/selftests/bpf/progs/tailcall5.c
>
[...]
next prev parent reply other threads:[~2019-11-22 23:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 20:07 [PATCH bpf-next v2 0/8] Optimize BPF tail calls for direct jumps Daniel Borkmann
2019-11-22 20:07 ` [PATCH bpf-next v2 1/8] bpf, x86: generalize and extend bpf_arch_text_poke " Daniel Borkmann
2019-11-22 20:07 ` [PATCH bpf-next v2 2/8] bpf: move bpf_free_used_maps into sleepable section Daniel Borkmann
2019-11-22 20:07 ` [PATCH bpf-next v2 3/8] bpf: move owner type,jited info into array auxiliary data Daniel Borkmann
2019-11-22 20:07 ` [PATCH bpf-next v2 4/8] bpf: add initial poke descriptor table for jit images Daniel Borkmann
2019-11-22 20:07 ` [PATCH bpf-next v2 5/8] bpf: add poke dependency tracking for prog array maps Daniel Borkmann
2019-11-22 22:55 ` Andrii Nakryiko
2019-11-22 23:06 ` Daniel Borkmann
2019-11-22 23:10 ` Andrii Nakryiko
2019-11-22 20:07 ` [PATCH bpf-next v2 6/8] bpf: constant map key tracking for prog array pokes Daniel Borkmann
2019-11-22 22:57 ` Andrii Nakryiko
2019-11-23 10:39 ` Jakub Sitnicki
2019-11-22 20:08 ` [PATCH bpf-next v2 7/8] bpf, x86: emit patchable direct jump as tail call Daniel Borkmann
2019-11-22 23:09 ` Andrii Nakryiko
2019-11-22 23:25 ` Daniel Borkmann
2019-11-23 2:28 ` Alexei Starovoitov
2019-11-23 5:00 ` Andrii Nakryiko
2019-11-23 6:18 ` Alexei Starovoitov
2019-11-23 9:24 ` Daniel Borkmann
2019-11-22 20:08 ` [PATCH bpf-next v2 8/8] bpf, testing: add various tail call test cases Daniel Borkmann
2019-11-22 23:14 ` Andrii Nakryiko [this message]
2019-11-23 2:22 ` [PATCH bpf-next v2 0/8] Optimize BPF tail calls for direct jumps Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEf4BzbLeKYC7WJtqDkZQh6sVm4dw-aFgtUsO2Phb8DDxzaDEw@mail.gmail.com \
--to=andrii.nakryiko@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).