From: Y Song <ys114321@gmail.com>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Daniel Borkmann <daniel@iogearbox.net>,
netdev <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
oss-drivers@netronome.com
Subject: Re: [PATCH bpf 0/2] tools: bpftool: fix pinning error messages
Date: Tue, 6 Aug 2019 23:15:38 -0700 [thread overview]
Message-ID: <CAH3MdRUxrZvTr-fBumsb0UhRkYq+9emig4+Ewpse7JsgQz99LA@mail.gmail.com> (raw)
In-Reply-To: <20190807001923.19483-1-jakub.kicinski@netronome.com>
On Tue, Aug 6, 2019 at 5:20 PM Jakub Kicinski
<jakub.kicinski@netronome.com> wrote:
>
> Hi!
>
> First make sure we don't use "prog" in error messages because
> the pinning operation could be performed on a map. Second add
> back missing error message if pin syscall failed.
>
> Jakub Kicinski (2):
> tools: bpftool: fix error message (prog -> object)
> tools: bpftool: add error message on pin failure
Looks good to me. Ack the whole series.
Acked-by: Yonghong Song <yhs@fb.com>
>
> tools/bpf/bpftool/common.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> --
> 2.21.0
>
next prev parent reply other threads:[~2019-08-07 6:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 0:19 [PATCH bpf 0/2] tools: bpftool: fix pinning error messages Jakub Kicinski
2019-08-07 0:19 ` [PATCH bpf 1/2] tools: bpftool: fix error message (prog -> object) Jakub Kicinski
2019-08-07 0:19 ` [PATCH bpf 2/2] tools: bpftool: add error message on pin failure Jakub Kicinski
2019-08-08 18:54 ` Andrii Nakryiko
2019-08-07 6:15 ` Y Song [this message]
2019-08-09 15:43 ` [PATCH bpf 0/2] tools: bpftool: fix pinning error messages Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAH3MdRUxrZvTr-fBumsb0UhRkYq+9emig4+Ewpse7JsgQz99LA@mail.gmail.com \
--to=ys114321@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).