From: Stanislav Fomichev <sdf@google.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: daniel@iogearbox.net, ast@kernel.org, andrii@kernel.org,
martin.lau@linux.dev, song@kernel.org, yhs@fb.com,
john.fastabend@gmail.com, kpsingh@kernel.org, haoluo@google.com,
jolsa@kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH bpf] bpf: netdev: init the offload table earlier
Date: Fri, 5 May 2023 15:02:16 -0700 [thread overview]
Message-ID: <CAKH8qBvmk6bEoasBKvD_AECvtjUJX2JUJiApmo8RMc1GHadG=g@mail.gmail.com> (raw)
In-Reply-To: <20230505215836.491485-1-kuba@kernel.org>
On Fri, May 5, 2023 at 2:59 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> Some netdevices may get unregistered before late_initcall(),
> we have to move the hashtable init earlier.
>
> Fixes: f1fc43d03946 ("bpf: Move offload initialization into late_initcall")
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217399
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Acked-by: Stanislav Fomichev <sdf@google.com>
Make sense, thank you!
> ---
> CC: ast@kernel.org
> CC: daniel@iogearbox.net
> CC: andrii@kernel.org
> CC: martin.lau@linux.dev
> CC: song@kernel.org
> CC: yhs@fb.com
> CC: john.fastabend@gmail.com
> CC: kpsingh@kernel.org
> CC: sdf@google.com
> CC: haoluo@google.com
> CC: jolsa@kernel.org
> CC: bpf@vger.kernel.org
> ---
> kernel/bpf/offload.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/bpf/offload.c b/kernel/bpf/offload.c
> index d9c9f45e3529..8a26cd8814c1 100644
> --- a/kernel/bpf/offload.c
> +++ b/kernel/bpf/offload.c
> @@ -859,4 +859,4 @@ static int __init bpf_offload_init(void)
> return rhashtable_init(&offdevs, &offdevs_params);
> }
>
> -late_initcall(bpf_offload_init);
> +core_initcall(bpf_offload_init);
> --
> 2.40.1
>
prev parent reply other threads:[~2023-05-05 22:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-05 21:58 [PATCH bpf] bpf: netdev: init the offload table earlier Jakub Kicinski
2023-05-05 22:02 ` Stanislav Fomichev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKH8qBvmk6bEoasBKvD_AECvtjUJX2JUJiApmo8RMc1GHadG=g@mail.gmail.com' \
--to=sdf@google.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=martin.lau@linux.dev \
--cc=song@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).