From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org,
lorenzo.bianconi@redhat.com, davem@davemloft.net,
kuba@kernel.org, ast@kernel.org, daniel@iogearbox.net,
shayagr@amazon.com, sameehj@amazon.com, john.fastabend@gmail.com,
dsahern@kernel.org, brouer@redhat.com, echaudro@redhat.com,
jasowang@redhat.com, alexander.duyck@gmail.com, saeed@kernel.org,
maciej.fijalkowski@intel.com
Subject: Re: [PATCH v8 bpf-next 05/14] net: mvneta: add multi buffer support to XDP_TX
Date: Fri, 9 Apr 2021 18:36:05 +0200 [thread overview]
Message-ID: <YHCCdSqCByo9JVp+@lore-desk> (raw)
In-Reply-To: <20210408184002.k2om3nrittvh7z45@skbuf>
[-- Attachment #1: Type: text/plain, Size: 6415 bytes --]
> On Thu, Apr 08, 2021 at 02:50:57PM +0200, Lorenzo Bianconi wrote:
> > Introduce the capability to map non-linear xdp buffer running
> > mvneta_xdp_submit_frame() for XDP_TX and XDP_REDIRECT
> >
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > ---
> > drivers/net/ethernet/marvell/mvneta.c | 94 +++++++++++++++++----------
> > 1 file changed, 58 insertions(+), 36 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
> > index 94e29cce693a..e95d8df0fcdb 100644
> > --- a/drivers/net/ethernet/marvell/mvneta.c
> > +++ b/drivers/net/ethernet/marvell/mvneta.c
> > @@ -1860,8 +1860,8 @@ static void mvneta_txq_bufs_free(struct mvneta_port *pp,
> > bytes_compl += buf->skb->len;
> > pkts_compl++;
> > dev_kfree_skb_any(buf->skb);
> > - } else if (buf->type == MVNETA_TYPE_XDP_TX ||
> > - buf->type == MVNETA_TYPE_XDP_NDO) {
> > + } else if ((buf->type == MVNETA_TYPE_XDP_TX ||
> > + buf->type == MVNETA_TYPE_XDP_NDO) && buf->xdpf) {
> > if (napi && buf->type == MVNETA_TYPE_XDP_TX)
> > xdp_return_frame_rx_napi(buf->xdpf);
> > else
> > @@ -2057,45 +2057,67 @@ mvneta_xdp_put_buff(struct mvneta_port *pp, struct mvneta_rx_queue *rxq,
> >
> > static int
> > mvneta_xdp_submit_frame(struct mvneta_port *pp, struct mvneta_tx_queue *txq,
> > - struct xdp_frame *xdpf, bool dma_map)
> > + struct xdp_frame *xdpf, int *nxmit_byte, bool dma_map)
> > {
> > - struct mvneta_tx_desc *tx_desc;
> > - struct mvneta_tx_buf *buf;
> > - dma_addr_t dma_addr;
> > + struct mvneta_tx_desc *tx_desc = NULL;
> > + struct xdp_shared_info *xdp_sinfo;
> > + struct page *page;
> > + int i, num_frames;
> > +
> > + xdp_sinfo = xdp_get_shared_info_from_frame(xdpf);
> > + num_frames = xdpf->mb ? xdp_sinfo->nr_frags + 1 : 1;
> >
> > - if (txq->count >= txq->tx_stop_threshold)
> > + if (txq->count + num_frames >= txq->size)
> > return MVNETA_XDP_DROPPED;
> >
> > - tx_desc = mvneta_txq_next_desc_get(txq);
> > + for (i = 0; i < num_frames; i++) {
>
> I get the feeling this is more like num_bufs than num_frames.
naming is the hardest part :)
>
> > + struct mvneta_tx_buf *buf = &txq->buf[txq->txq_put_index];
> > + skb_frag_t *frag = i ? &xdp_sinfo->frags[i - 1] : NULL;
> > + int len = i ? xdp_get_frag_size(frag) : xdpf->len;
> > + dma_addr_t dma_addr;
> >
> > - buf = &txq->buf[txq->txq_put_index];
> > - if (dma_map) {
> > - /* ndo_xdp_xmit */
> > - dma_addr = dma_map_single(pp->dev->dev.parent, xdpf->data,
> > - xdpf->len, DMA_TO_DEVICE);
> > - if (dma_mapping_error(pp->dev->dev.parent, dma_addr)) {
> > - mvneta_txq_desc_put(txq);
> > - return MVNETA_XDP_DROPPED;
> > + tx_desc = mvneta_txq_next_desc_get(txq);
> > + if (dma_map) {
> > + /* ndo_xdp_xmit */
> > + void *data;
> > +
> > + data = frag ? xdp_get_frag_address(frag) : xdpf->data;
> > + dma_addr = dma_map_single(pp->dev->dev.parent, data,
> > + len, DMA_TO_DEVICE);
> > + if (dma_mapping_error(pp->dev->dev.parent, dma_addr)) {
> > + for (; i >= 0; i--)
> > + mvneta_txq_desc_put(txq);
>
> Don't you need to unmap the previous buffers too?
ack, right since these buffers do not belong to the pool, I will fix it.
Regards,
Lorenzo
>
> > + return MVNETA_XDP_DROPPED;
> > + }
> > + buf->type = MVNETA_TYPE_XDP_NDO;
> > + } else {
> > + page = frag ? xdp_get_frag_page(frag)
> > + : virt_to_page(xdpf->data);
> > + dma_addr = page_pool_get_dma_addr(page);
> > + if (frag)
> > + dma_addr += xdp_get_frag_offset(frag);
> > + else
> > + dma_addr += sizeof(*xdpf) + xdpf->headroom;
> > + dma_sync_single_for_device(pp->dev->dev.parent,
> > + dma_addr, len,
> > + DMA_BIDIRECTIONAL);
> > + buf->type = MVNETA_TYPE_XDP_TX;
> > }
> > - buf->type = MVNETA_TYPE_XDP_NDO;
> > - } else {
> > - struct page *page = virt_to_page(xdpf->data);
> > + buf->xdpf = i ? NULL : xdpf;
> >
> > - dma_addr = page_pool_get_dma_addr(page) +
> > - sizeof(*xdpf) + xdpf->headroom;
> > - dma_sync_single_for_device(pp->dev->dev.parent, dma_addr,
> > - xdpf->len, DMA_BIDIRECTIONAL);
> > - buf->type = MVNETA_TYPE_XDP_TX;
> > + tx_desc->command = !i ? MVNETA_TXD_F_DESC : 0;
> > + tx_desc->buf_phys_addr = dma_addr;
> > + tx_desc->data_size = len;
> > + *nxmit_byte += len;
> > +
> > + mvneta_txq_inc_put(txq);
> > }
> > - buf->xdpf = xdpf;
> >
> > - tx_desc->command = MVNETA_TXD_FLZ_DESC;
> > - tx_desc->buf_phys_addr = dma_addr;
> > - tx_desc->data_size = xdpf->len;
> > + /*last descriptor */
> > + tx_desc->command |= MVNETA_TXD_L_DESC | MVNETA_TXD_Z_PAD;
> >
> > - mvneta_txq_inc_put(txq);
> > - txq->pending++;
> > - txq->count++;
> > + txq->pending += num_frames;
> > + txq->count += num_frames;
> >
> > return MVNETA_XDP_TX;
> > }
> > @@ -2106,8 +2128,8 @@ mvneta_xdp_xmit_back(struct mvneta_port *pp, struct xdp_buff *xdp)
> > struct mvneta_pcpu_stats *stats = this_cpu_ptr(pp->stats);
> > struct mvneta_tx_queue *txq;
> > struct netdev_queue *nq;
> > + int cpu, nxmit_byte = 0;
> > struct xdp_frame *xdpf;
> > - int cpu;
> > u32 ret;
> >
> > xdpf = xdp_convert_buff_to_frame(xdp);
> > @@ -2119,10 +2141,10 @@ mvneta_xdp_xmit_back(struct mvneta_port *pp, struct xdp_buff *xdp)
> > nq = netdev_get_tx_queue(pp->dev, txq->id);
> >
> > __netif_tx_lock(nq, cpu);
> > - ret = mvneta_xdp_submit_frame(pp, txq, xdpf, false);
> > + ret = mvneta_xdp_submit_frame(pp, txq, xdpf, &nxmit_byte, false);
> > if (ret == MVNETA_XDP_TX) {
> > u64_stats_update_begin(&stats->syncp);
> > - stats->es.ps.tx_bytes += xdpf->len;
> > + stats->es.ps.tx_bytes += nxmit_byte;
> > stats->es.ps.tx_packets++;
> > stats->es.ps.xdp_tx++;
> > u64_stats_update_end(&stats->syncp);
> > @@ -2161,11 +2183,11 @@ mvneta_xdp_xmit(struct net_device *dev, int num_frame,
> >
> > __netif_tx_lock(nq, cpu);
> > for (i = 0; i < num_frame; i++) {
> > - ret = mvneta_xdp_submit_frame(pp, txq, frames[i], true);
> > + ret = mvneta_xdp_submit_frame(pp, txq, frames[i], &nxmit_byte,
> > + true);
> > if (ret != MVNETA_XDP_TX)
> > break;
> >
> > - nxmit_byte += frames[i]->len;
> > nxmit++;
> > }
> >
> > --
> > 2.30.2
> >
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2021-04-09 16:36 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 12:50 [PATCH v8 bpf-next 00/14] mvneta: introduce XDP multi-buffer support Lorenzo Bianconi
2021-04-08 12:50 ` [PATCH v8 bpf-next 01/14] xdp: introduce mb in xdp_buff/xdp_frame Lorenzo Bianconi
2021-04-08 18:17 ` Vladimir Oltean
2021-04-09 16:03 ` Lorenzo Bianconi
2021-04-29 13:36 ` Jesper Dangaard Brouer
2021-04-29 13:54 ` Lorenzo Bianconi
2021-04-08 12:50 ` [PATCH v8 bpf-next 02/14] xdp: add xdp_shared_info data structure Lorenzo Bianconi
2021-04-08 13:39 ` Vladimir Oltean
2021-04-08 14:26 ` Lorenzo Bianconi
2021-04-08 18:06 ` kernel test robot
2021-04-08 12:50 ` [PATCH v8 bpf-next 03/14] net: mvneta: update mb bit before passing the xdp buffer to eBPF layer Lorenzo Bianconi
2021-04-08 18:19 ` Vladimir Oltean
2021-04-09 16:24 ` Lorenzo Bianconi
2021-04-08 12:50 ` [PATCH v8 bpf-next 04/14] xdp: add multi-buff support to xdp_return_{buff/frame} Lorenzo Bianconi
2021-04-08 18:30 ` Vladimir Oltean
2021-04-09 16:28 ` Lorenzo Bianconi
2021-04-08 12:50 ` [PATCH v8 bpf-next 05/14] net: mvneta: add multi buffer support to XDP_TX Lorenzo Bianconi
2021-04-08 18:40 ` Vladimir Oltean
2021-04-09 16:36 ` Lorenzo Bianconi [this message]
2021-04-08 12:50 ` [PATCH v8 bpf-next 06/14] net: mvneta: enable jumbo frames for XDP Lorenzo Bianconi
2021-04-08 12:50 ` [PATCH v8 bpf-next 07/14] net: xdp: add multi-buff support to xdp_build_skb_from_fram Lorenzo Bianconi
2021-04-08 12:51 ` [PATCH v8 bpf-next 08/14] bpf: add multi-buff support to the bpf_xdp_adjust_tail() API Lorenzo Bianconi
2021-04-08 19:15 ` Vladimir Oltean
2021-04-08 20:54 ` Vladimir Oltean
2021-04-09 18:13 ` Lorenzo Bianconi
2021-04-08 12:51 ` [PATCH v8 bpf-next 09/14] bpd: add multi-buffer support to xdp copy helpers Lorenzo Bianconi
2021-04-08 20:57 ` Vladimir Oltean
2021-04-09 18:19 ` Lorenzo Bianconi
2021-04-08 21:04 ` Vladimir Oltean
2021-04-14 8:08 ` Eelco Chaudron
2021-04-08 12:51 ` [PATCH v8 bpf-next 10/14] bpf: add new frame_length field to the XDP ctx Lorenzo Bianconi
2021-04-08 12:51 ` [PATCH v8 bpf-next 11/14] bpf: move user_size out of bpf_test_init Lorenzo Bianconi
2021-04-08 12:51 ` [PATCH v8 bpf-next 12/14] bpf: introduce multibuff support to bpf_prog_test_run_xdp() Lorenzo Bianconi
2021-04-08 12:51 ` [PATCH v8 bpf-next 13/14] bpf: test_run: add xdp_shared_info pointer in bpf_test_finish signature Lorenzo Bianconi
2021-04-08 12:51 ` [PATCH v8 bpf-next 14/14] bpf: update xdp_adjust_tail selftest to include multi-buffer Lorenzo Bianconi
2021-04-09 0:56 ` [PATCH v8 bpf-next 00/14] mvneta: introduce XDP multi-buffer support John Fastabend
2021-04-09 20:16 ` Lorenzo Bianconi
2021-04-13 15:16 ` Eelco Chaudron
2021-04-16 14:27 ` Magnus Karlsson
2021-04-16 21:29 ` Lorenzo Bianconi
2021-04-16 23:00 ` Daniel Borkmann
2021-04-18 16:18 ` Jesper Dangaard Brouer
2021-04-19 6:20 ` Magnus Karlsson
2021-04-19 6:55 ` Lorenzo Bianconi
2021-04-20 13:49 ` Magnus Karlsson
2021-04-21 12:47 ` Jesper Dangaard Brouer
2021-04-21 14:12 ` Magnus Karlsson
2021-04-21 15:39 ` Jesper Dangaard Brouer
2021-04-22 10:24 ` Magnus Karlsson
2021-04-22 14:42 ` Jesper Dangaard Brouer
2021-04-22 15:05 ` Crash for i40e on net-next (was: [PATCH v8 bpf-next 00/14] mvneta: introduce XDP multi-buffer support) Jesper Dangaard Brouer
2021-04-23 5:28 ` Magnus Karlsson
2021-04-23 16:43 ` Alexander Duyck
2021-04-25 9:45 ` Magnus Karlsson
2021-04-27 18:28 ` [PATCH v8 bpf-next 00/14] mvneta: introduce XDP multi-buffer support Lorenzo Bianconi
2021-04-28 7:41 ` Magnus Karlsson
2021-04-29 12:49 ` Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHCCdSqCByo9JVp+@lore-desk \
--to=lorenzo@kernel.org \
--cc=alexander.duyck@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=echaudro@redhat.com \
--cc=jasowang@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=maciej.fijalkowski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=saeed@kernel.org \
--cc=sameehj@amazon.com \
--cc=shayagr@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).