From: Kent Overstreet <kent.overstreet@linux.dev>
To: Song Liu <song@kernel.org>
Cc: linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
mcgrof@kernel.org, peterz@infradead.org, tglx@linutronix.de,
x86@kernel.org, rppt@kernel.org
Subject: Re: [PATCH 0/3] Type aware module allocator
Date: Thu, 1 Jun 2023 13:53:08 -0400 [thread overview]
Message-ID: <ZHjbBAnpkfw2oBCr@moria.home.lan> (raw)
In-Reply-To: <CAPhsuW6hqzLuNhvkHFOmKTJdQm8A0JdUna=1iFdRC0y+kKmF4Q@mail.gmail.com>
On Tue, May 30, 2023 at 03:48:51PM -0700, Song Liu wrote:
> On Mon, May 29, 2023 at 11:25 AM Kent Overstreet
> <kent.overstreet@linux.dev> wrote:
> >
> > On Sat, May 27, 2023 at 10:58:37PM -0700, Song Liu wrote:
> > > I don't think we are exposing architecture specific options to users.
> > > Some layer need to handle arch specifics. If the new allocator is
> > > built on top of module_alloc, module_alloc is handling that. If the new
> > > allocator is to replace module_alloc, it needs to handle arch specifics.
> >
> > Ok, I went back and read more thoroughly, I got this part wrong. The
> > actual interface is the mod_mem_type enum, not mod_alloc_params or
> > vmalloc_params.
> >
> > So this was my main complaint, but this actually looks ok now.
> >
> > It would be better to have those structs in a .c file, not the header
> > file - it looks like those are the public interface the way you have it.
>
> Thanks for this suggestion. It makes a lot of sense. But I am not quite
> sure how we can avoid putting it in the header yet. I will take a closer
> look. OTOH, if we plan to use Mike's new allocator to replace vmalloc,
> we probably don't need this part.
The architectures previously exported constants that were used by
module_alloc(), why not stick with that?
> AFAICT, we don't have a global text_poke() API yet. I can take a look
> into it (if it makes sense).
Great
> Yeah, that's part of the goal to extend the scope from executable to all
> types.
Yeah it took me a bit to wrap my head around how this all makes sense -
it started out as just a better module_alloc(), then there was lots of
talk about hugepages.
I like it more now, looking forward to see how it fits together with
Mike's work :)
next prev parent reply other threads:[~2023-06-01 17:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 5:15 [PATCH 0/3] Type aware module allocator Song Liu
2023-05-26 5:15 ` [PATCH 1/3] module: Introduce module_alloc_type Song Liu
2023-05-26 6:07 ` Randy Dunlap
2023-05-26 22:29 ` Kent Overstreet
2023-05-26 23:09 ` Song Liu
2023-05-26 23:39 ` Kent Overstreet
2023-05-27 0:03 ` Song Liu
2023-05-27 3:19 ` Kent Overstreet
2023-05-27 6:00 ` Song Liu
2023-05-26 5:15 ` [PATCH 2/3] ftrace: Add swap_func to ftrace_process_locs() Song Liu
2023-05-26 5:15 ` [PATCH 3/3] x86/module: Use module_alloc_type Song Liu
2023-05-27 7:04 ` [PATCH 0/3] Type aware module allocator Kent Overstreet
2023-05-28 5:58 ` Song Liu
2023-05-29 10:45 ` Mike Rapoport
2023-05-30 22:37 ` Song Liu
2023-05-31 13:51 ` Mike Rapoport
2023-05-31 17:03 ` Song Liu
2023-05-31 19:54 ` Mike Rapoport
2023-05-29 18:25 ` Kent Overstreet
2023-05-30 22:48 ` Song Liu
2023-06-01 17:53 ` Kent Overstreet [this message]
2023-06-01 18:21 ` Kent Overstreet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHjbBAnpkfw2oBCr@moria.home.lan \
--to=kent.overstreet@linux.dev \
--cc=bpf@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=peterz@infradead.org \
--cc=rppt@kernel.org \
--cc=song@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).