From: Anton Protopopov <aspsk@isovalent.com>
To: Hou Tao <houtao@huaweicloud.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
John Fastabend <john.fastabend@gmail.com>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>,
bpf@vger.kernel.org
Subject: Re: [v3 PATCH bpf-next 5/6] selftests/bpf: test map percpu stats
Date: Wed, 5 Jul 2023 15:41:35 +0000 [thread overview]
Message-ID: <ZKWPL4OsRqJcTQbJ@zh-lab-node-5> (raw)
In-Reply-To: <ec62d127-2cc5-3f0a-6eb7-d77a9aaaa7a3@huaweicloud.com>
On Wed, Jul 05, 2023 at 08:46:09AM +0800, Hou Tao wrote:
> Hi,
>
> On 7/4/2023 11:23 PM, Anton Protopopov wrote:
> > On Tue, Jul 04, 2023 at 03:02:32PM +0000, Anton Protopopov wrote:
> >> On Tue, Jul 04, 2023 at 10:41:10PM +0800, Hou Tao wrote:
> >>> Hi,
> >>>
> >>> On 6/30/2023 4:25 PM, Anton Protopopov wrote:
> >>> [...]
> >>>> +}
> >>>> +
> >>>> +void test_map_percpu_stats(void)
> >>>> +{
> >>>> + map_percpu_stats_hash();
> >>>> + map_percpu_stats_percpu_hash();
> >>>> + map_percpu_stats_hash_prealloc();
> >>>> + map_percpu_stats_percpu_hash_prealloc();
> >>>> + map_percpu_stats_lru_hash();
> >>>> + map_percpu_stats_percpu_lru_hash();
> >>>> +}
> >>> Please use test__start_subtest() to create multiple subtests.
> > After looking at code, I think that I will leave the individual functions here,
> > as the test__start_subtest() function is only implemented in test_progs (not
> > test_maps), and adding it here looks like out of scope for this patch.
> > .
> I see. But can we just add these tests in test_progs instead which is
> more flexible ?
I think that it makes more sense to port this test_prog flexibility to the
test_maps program. I can volunteer to do this (but not right away).
next prev parent reply other threads:[~2023-07-05 15:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 8:25 [v3 PATCH bpf-next 0/6] bpf: add percpu stats for bpf_map Anton Protopopov
2023-06-30 8:25 ` [v3 PATCH bpf-next 1/6] bpf: add percpu stats for bpf_map elements insertions/deletions Anton Protopopov
2023-06-30 8:25 ` [v3 PATCH bpf-next 2/6] bpf: add a new kfunc to return current bpf_map elements count Anton Protopopov
2023-06-30 8:25 ` [v3 PATCH bpf-next 3/6] bpf: populate the per-cpu insertions/deletions counters for hashmaps Anton Protopopov
2023-07-04 13:56 ` Hou Tao
2023-07-04 14:34 ` Anton Protopopov
2023-07-06 2:01 ` Hou Tao
2023-07-06 12:25 ` Anton Protopopov
2023-07-06 12:30 ` Hou Tao
2023-06-30 8:25 ` [v3 PATCH bpf-next 4/6] bpf: make preloaded map iterators to display map elements count Anton Protopopov
2023-06-30 8:25 ` [v3 PATCH bpf-next 5/6] selftests/bpf: test map percpu stats Anton Protopopov
2023-07-04 14:41 ` Hou Tao
2023-07-04 15:02 ` Anton Protopopov
2023-07-04 15:23 ` Anton Protopopov
2023-07-04 15:49 ` Anton Protopopov
2023-07-05 0:46 ` Hou Tao
2023-07-05 15:41 ` Anton Protopopov [this message]
2023-07-05 3:03 ` Hou Tao
2023-07-05 15:34 ` Anton Protopopov
2023-06-30 8:25 ` [v3 PATCH bpf-next 6/6] selftests/bpf: check that ->elem_count is non-zero for the hash map Anton Protopopov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZKWPL4OsRqJcTQbJ@zh-lab-node-5 \
--to=aspsk@isovalent.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=houtao@huaweicloud.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=martin.lau@linux.dev \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).