From: Edward Cree <ecree.xilinx@gmail.com>
To: Lorenz Bauer <lmb@cloudflare.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>
Cc: kernel-team@cloudflare.com, netdev@vger.kernel.org,
bpf@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH bpf-next 3/3] bpf: verifier: allocate idmap scratch in verifier env
Date: Thu, 29 Apr 2021 15:52:47 +0100 [thread overview]
Message-ID: <a467432f-065a-1b3b-b7eb-7e62f70918bf@gmail.com> (raw)
In-Reply-To: <20210429134656.122225-4-lmb@cloudflare.com>
On 29/04/2021 14:46, Lorenz Bauer wrote:
> func_states_equal makes a very short lived allocation for idmap,
> probably because it's too large to fit on the stack. However the
> function is called quite often, leading to a lot of alloc / free
> churn. Replace the temporary allocation with dedicated scratch
> space in struct bpf_verifier_env.
>
> Signed-off-by: Lorenz Bauer <lmb@cloudflare.com>
Acked-by: Edward Cree <ecree.xilinx@gmail.com>
next prev parent reply other threads:[~2021-04-29 14:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 13:46 [PATCH bpf-next 0/3] Reduce kmalloc / kfree churn in the verifier Lorenz Bauer
2021-04-29 13:46 ` [PATCH bpf-next 1/3] bpf: verifier: improve function state reallocation Lorenz Bauer
2021-04-29 13:46 ` [PATCH bpf-next 2/3] bpf: verifier: use copy_array for jmp_history Lorenz Bauer
2021-04-29 13:46 ` [PATCH bpf-next 3/3] bpf: verifier: allocate idmap scratch in verifier env Lorenz Bauer
2021-04-29 14:52 ` Edward Cree [this message]
2021-05-11 0:55 ` [PATCH bpf-next 0/3] Reduce kmalloc / kfree churn in the verifier Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a467432f-065a-1b3b-b7eb-7e62f70918bf@gmail.com \
--to=ecree.xilinx@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@cloudflare.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lmb@cloudflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).