From: Daniel Borkmann <daniel@iogearbox.net>
To: "Lorenz Bauer" <lmb@cloudflare.com>,
"Maciej Żenczykowski" <zenczykowski@gmail.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Linux Network Development Mailing List <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
BPF Mailing List <bpf@vger.kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Andrii Nakryiko <andrii@kernel.org>,
Greg Kroah-Hartman <gregkh@google.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Lorenzo Colitti <lorenzo@google.com>
Subject: Re: [PATCH bpf] Revert "bpf: program: Refuse non-O_RDWR flags in BPF_OBJ_GET"
Date: Tue, 22 Jun 2021 15:03:58 +0200 [thread overview]
Message-ID: <a703516a-1566-d5fe-cf4c-f2bb004a4f4e@iogearbox.net> (raw)
In-Reply-To: <CACAyw98B=uCnDY1tTw5STLUgNKvJeksJjaKiGqasJEEVv99GqA@mail.gmail.com>
On 6/22/21 10:59 AM, Lorenz Bauer wrote:
> On Mon, 21 Jun 2021 at 22:37, Maciej Żenczykowski
> <zenczykowski@gmail.com> wrote:
>>
>> Please revert immediately. I've got better things to do. I shouldn't
>> have to be thinking about this or arguing about this.
>> It already took me significantly more than a day simply to track this
>> down (arguably due to miscommunications with Greg, who'd earlier
>> actually found this in 5.12, but misunderstood the problem, but
>> still...).
>
> You're barking up the wrong tree. I don't object to reverting the
> patch, you asked me for context and I gave it to you.
+1, this kind of barking was unnecessary and inappropriate.
I revamped the commit message a bit to have some more context for future
reference when we need to get back on this.
Anyway, applied.
next prev parent reply other threads:[~2021-06-22 13:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 10:55 [PATCH bpf] Revert "bpf: program: Refuse non-O_RDWR flags in BPF_OBJ_GET" Maciej Żenczykowski
2021-06-18 11:55 ` Lorenz Bauer
2021-06-18 18:38 ` Maciej Żenczykowski
[not found] ` <CANP3RGdrpb+KiD+a29zTSU3LKR8Qo6aFdo4QseRvPdNhZ_AOJw@mail.gmail.com>
2021-06-21 9:02 ` Lorenz Bauer
2021-06-21 21:37 ` Maciej Żenczykowski
2021-06-22 8:59 ` Lorenz Bauer
2021-06-22 13:03 ` Daniel Borkmann [this message]
2021-06-25 0:27 ` Maciej Żenczykowski
2021-06-22 9:48 ` Greg Kroah-Hartman
2021-06-23 8:44 ` Lorenz Bauer
2021-06-25 0:13 ` Maciej Żenczykowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a703516a-1566-d5fe-cf4c-f2bb004a4f4e@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=gregkh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lmb@cloudflare.com \
--cc=lorenzo@google.com \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=zenczykowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).