From: 白浩文 <baihaowen@meizu.com>
To: Martin KaFai Lau <kafai@fb.com>
Cc: "shuah@kernel.org" <shuah@kernel.org>,
"ast@kernel.org" <ast@kernel.org>,
"daniel@iogearbox.net" <daniel@iogearbox.net>,
"andrii@kernel.org" <andrii@kernel.org>,
"songliubraving@fb.com" <songliubraving@fb.com>,
"yhs@fb.com" <yhs@fb.com>,
"john.fastabend@gmail.com" <john.fastabend@gmail.com>,
"kpsingh@kernel.org" <kpsingh@kernel.org>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: 答复: [PATCH] selftests/bpf: Fix warning comparing pointer to 0
Date: Fri, 25 Mar 2022 01:15:41 +0000 [thread overview]
Message-ID: <c1b8dd58744345538d122468e4c0def3@meizu.com> (raw)
In-Reply-To: <20220324202848.2ncrqbzv3dv5qifo@kafai-mbp>
hi, kafai
./scripts/coccicheck report this warning.
________________________________________
发件人: Martin KaFai Lau <kafai@fb.com>
发送时间: 2022年3月25日 4:28:48
收件人: 白浩文
抄送: shuah@kernel.org; ast@kernel.org; daniel@iogearbox.net; andrii@kernel.org; songliubraving@fb.com; yhs@fb.com; john.fastabend@gmail.com; kpsingh@kernel.org; linux-kselftest@vger.kernel.org; netdev@vger.kernel.org; bpf@vger.kernel.org; linux-kernel@vger.kernel.org
主题: Re: [PATCH] selftests/bpf: Fix warning comparing pointer to 0
On Thu, Mar 24, 2022 at 10:08:45AM +0800, Haowen Bai wrote:
> Avoid pointer type value compared with 0 to make code clear.
Which compiler version that warns ?
I don't see it with the latest llvm-project from github.
The patch lgtm.
Acked-by: Martin KaFai Lau <kafai@fb.com>
next prev parent reply other threads:[~2022-03-25 1:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 2:08 [PATCH] selftests/bpf: Fix warning comparing pointer to 0 Haowen Bai
2022-03-24 20:28 ` Martin KaFai Lau
2022-03-25 1:15 ` 白浩文 [this message]
2022-03-25 19:55 ` Shuah Khan
2022-03-30 1:59 ` [PATCH V2] " Haowen Bai
2022-03-30 3:16 ` Yonghong Song
2022-03-30 13:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1b8dd58744345538d122468e4c0def3@meizu.com \
--to=baihaowen@meizu.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).