From: Kui-Feng Lee <sinquersw@gmail.com>
To: Martin KaFai Lau <martin.lau@linux.dev>, thinker.li@gmail.com
Cc: kuifeng@meta.com, bpf@vger.kernel.org, ast@kernel.org,
song@kernel.org, kernel-team@meta.com, andrii@kernel.org,
drosen@google.com
Subject: Re: [PATCH bpf-next v16 08/14] bpf: pass attached BTF to the bpf_struct_ops subsystem
Date: Fri, 19 Jan 2024 10:05:57 -0800 [thread overview]
Message-ID: <cce556a9-ca52-4dcb-8d3f-46f363162cac@gmail.com> (raw)
In-Reply-To: <c8ff1275-fbc2-4117-9f40-59072e129426@linux.dev>
On 1/18/24 13:56, Martin KaFai Lau wrote:
> On 1/17/24 5:49 PM, thinker.li@gmail.com wrote:
>> diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
>> index 0744a1f194fa..ff41f7736618 100644
>> --- a/kernel/bpf/verifier.c
>> +++ b/kernel/bpf/verifier.c
>> @@ -20234,6 +20234,7 @@ static int check_struct_ops_btf_id(struct
>> bpf_verifier_env *env)
>> const struct btf_member *member;
>> struct bpf_prog *prog = env->prog;
>> u32 btf_id, member_idx;
>> + struct btf *btf;
>> const char *mname;
>> if (!prog->gpl_compatible) {
>> @@ -20241,8 +20242,10 @@ static int check_struct_ops_btf_id(struct
>> bpf_verifier_env *env)
>> return -EINVAL;
>> }
>> + btf = prog->aux->attach_btf ?: bpf_get_btf_vmlinux();
>> +
>
> just "btf = prog->aux->attach_btf;" which was assigned to
> bpf_get_btf_vmlinux() for the non-module case. Take a look at
> bpf_prog_load() in syscall.c
You are right. I have been too protective here.
next prev parent reply other threads:[~2024-01-19 18:06 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 1:49 [PATCH bpf-next v16 00/14] Registrating struct_ops types from modules thinker.li
2024-01-18 1:49 ` [PATCH bpf-next v16 01/14] bpf: refactory struct_ops type initialization to a function thinker.li
2024-01-18 1:49 ` [PATCH bpf-next v16 02/14] bpf: get type information with BTF_ID_LIST thinker.li
2024-01-18 1:49 ` [PATCH bpf-next v16 03/14] bpf, net: introduce bpf_struct_ops_desc thinker.li
2024-01-18 21:30 ` Martin KaFai Lau
2024-01-19 0:47 ` Kui-Feng Lee
2024-01-18 1:49 ` [PATCH bpf-next v16 04/14] bpf: add struct_ops_tab to btf thinker.li
2024-01-18 21:36 ` Martin KaFai Lau
2024-01-19 1:13 ` Kui-Feng Lee
2024-01-18 1:49 ` [PATCH bpf-next v16 05/14] bpf: make struct_ops_map support btfs other than btf_vmlinux thinker.li
2024-01-18 1:49 ` [PATCH bpf-next v16 06/14] bpf: pass btf object id in bpf_map_info thinker.li
2024-01-18 21:42 ` Martin KaFai Lau
2024-01-19 21:38 ` Kui-Feng Lee
2024-01-18 1:49 ` [PATCH bpf-next v16 07/14] bpf: lookup struct_ops types from a given module BTF thinker.li
2024-01-18 1:49 ` [PATCH bpf-next v16 08/14] bpf: pass attached BTF to the bpf_struct_ops subsystem thinker.li
2024-01-18 21:56 ` Martin KaFai Lau
2024-01-19 18:05 ` Kui-Feng Lee [this message]
2024-01-19 18:43 ` Kui-Feng Lee
2024-01-18 1:49 ` [PATCH bpf-next v16 09/14] bpf: hold module refcnt in bpf_struct_ops map creation and prog verification thinker.li
2024-01-18 22:18 ` Martin KaFai Lau
2024-01-19 19:10 ` Kui-Feng Lee
2024-01-18 1:49 ` [PATCH bpf-next v16 10/14] bpf: validate value_type thinker.li
2024-01-18 1:49 ` [PATCH bpf-next v16 11/14] bpf, net: switch to dynamic registration thinker.li
2024-01-18 22:25 ` Martin KaFai Lau
2024-01-19 19:29 ` Kui-Feng Lee
2024-01-18 1:49 ` [PATCH bpf-next v16 12/14] libbpf: Find correct module BTFs for struct_ops maps and progs thinker.li
2024-01-18 1:49 ` [PATCH bpf-next v16 13/14] bpf: export btf_ctx_access to modules thinker.li
2024-01-18 1:49 ` [PATCH bpf-next v16 14/14] selftests/bpf: test case for register_bpf_struct_ops() thinker.li
2024-01-18 22:41 ` Martin KaFai Lau
2024-01-19 19:31 ` Kui-Feng Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cce556a9-ca52-4dcb-8d3f-46f363162cac@gmail.com \
--to=sinquersw@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=drosen@google.com \
--cc=kernel-team@meta.com \
--cc=kuifeng@meta.com \
--cc=martin.lau@linux.dev \
--cc=song@kernel.org \
--cc=thinker.li@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).